Closed Bug 1435621 Opened 2 years ago Closed 2 years ago

Remove SMILE from SeaMonkey

Categories

(SeaMonkey :: General, enhancement)

enhancement
Not set

Tracking

(seamonkey2.56 unaffected, seamonkey2.57esr fixed)

RESOLVED FIXED
seamonkey2.57
Tracking Status
seamonkey2.56 --- unaffected
seamonkey2.57esr --- fixed

People

(Reporter: frg, Assigned: frg)

References

Details

(Keywords: addon-compat)

Attachments

(1 file, 1 obsolete file)

nsIDOMHTMLDocument is now gone form gecko and this causes build bustage in smile. We discussed fixing it or taking smile out and after the latest round of api and interface removals in Gecko agreed to remove it completly. Bug 1388561 removed any internal dependencies.

+++ snip +++
A New bustage today with the following error:

21:46.18     -->
/home/wag/mozilla/seamonkey/sm-obj/dist/xpcrs/rt/smileIApplication.rs:1461:103
21:46.18      |
21:46.18 1461 |     pub GetDocument: unsafe extern "system" fn (this:
*const smileIBrowserTab, aDocument: *mut *const nsIDOMHTMLDocument) ->
nsresult,
21:46.18      |
                                               ^^^^^^^^^^^^^^^^^^ did
you mean `nsIDOMXMLDocument`?
21:46.18
21:46.18 error[E0412]: cannot find type `nsIDOMHTMLDocument` in this scope
21:46.19     -->
/home/wag/mozilla/seamonkey/sm-obj/dist/xpcrs/rt/smileIApplication.rs:1541:61
21:46.19      |
21:46.19 1541 |     pub unsafe fn GetDocument(&self, aDocument: *mut
*const nsIDOMHTMLDocument) -> nsresult {
21:46.19      |
     ^^^^^^^^^^^^^^^^^^ did you mean `nsIDOMXMLDocument`?

+++ snip 

+++ This bug was initially created as a clone of Bug #1388561 +++

+++ This bug was initially created as a clone of Bug #1278067 +++

Bug 1090880 has removed FUEL module from Firefox. The SeaMonkey equivalent is SMILE.

Bug 1354205 will remove the last traces of FUEL from the mozilla source tree. We are still using toolkit/components/exthelper/extApplication.js in SMILE. 

I am convinced that given the latest round of removals older add-ons will no longer function anyway with or without SMILE so I think it could be removed.

The alternative is to move exthelper to suite.
Attached patch 1435621-SMILEnoMore.patch (obsolete) — Splinter Review
Contains the unbittrotted removal parts from Bug 1388561:

https://bug1388561.bmoattachments.org/attachment.cgi?id=8895141
Attachment #8948277 - Flags: review?(iann_bugzilla)
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/629b9e240c8d
Remove SMILE module from SeaMonkey. rs=bustage-fix
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Got itchy and wanted to unbreak the build. Please give it a post review and/or slap me.
Attachment #8948277 - Attachment is obsolete: true
Attachment #8948277 - Flags: review?(iann_bugzilla)
Attachment #8948325 - Flags: review?(iann_bugzilla)
Comment on attachment 8948325 [details] [diff] [review]
1435621-SMILEnoMore.patch

r=me
Attachment #8948325 - Flags: review?(iann_bugzilla) → review+
Target Milestone: --- → Seamonkey2.57
nsIDOMHTMLDocument and Seamonkey are not really mentioned on MDN in any meaningful way these days, so I don't think there are really any docs for us to update.

Happy to revisit this if you don't agree. Thanks.
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.