1388619 - Remove proxy.onProxyError

Status: RESOLVED DUPLICATE of bug 1443259

(WebExtensions :: General, enhancement, P3)

Description

[erosman [:erosman]]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170805085114

Steps to reproduce:

Further to Bug 1371879 discussion which led to renaming and addition of proxy.register & proxy.unregister, it was agreed to rename proxy.onProxyError to proxy.onError but it seems the bug was never filled.


Further ref: Bug 1293751

Comment 1

[Shane Caraveo (:mixedpuppy)]

onError added and a deprecated note in schema in bug 1409878.  Probably before the next (after 60) esr we should remove the onProxyError listener.

Comment 2

[Manish [:manishkk]]

need to remove these only?
https://searchfox.org/mozilla-central/search?q=proxy.onProxyError&case=false&regexp=false&path=

Comment 3

[erosman [:erosman]]

It would be better to ask Shane

Comment 4

[Shane Caraveo (:mixedpuppy)]

The use in the tests should change to proxy.onError.

The implementation in ext-proxy would be removed.

Prior to doing this, we need to go through whatever process we need to do for deprecating/removal of these.

https://wiki.mozilla.org/WebExtensions/DeprecationPolicy

We should probably start this process for onProxyError and register/unregister if someone wants to drive that.

Lets see if Mike wants to, or if we can drive that via contributor.

Comment 5

[Mike Conca [:mconca]]

I plan to drive the deprecation process for both proxy.onProxyError and proxy.register/unregister.

Comment 6

[Mike Conca [:mconca]]

Going back to the original (accurate) title.

Target is Firefox 71.

Comment 7

[Shane Caraveo (:mixedpuppy)]

This will just be part of bug 1443259