1443259 - Remove proxy.register/unregister

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, enhancement, P2)

Description

[Shane Caraveo (:mixedpuppy)]

The initial proxy api created a pseudo-pac script since the proxy filter system was synchronous at that stage.  It never implemented the PAC APIs (partly due to a requirement for synchronous DNS in them), so normal in-the-wild PAC scripts will not work with this.  Now that an asynchronous api has landed, we should deprecate the old stuff and get it removed eventually.

Comment 5

[Shane Caraveo (:mixedpuppy)]

bug 1456786 is unrelated to the proxy api.

Comment 6

[Rob Wu [:robwu]]

FYI: bug 1456786 contains one note that is relevant to the proxy.register API:

> The only reason for subscribing to messages on the parent process manager is:
> - ProxyScriptContext
>   * context.messageManager = cpmm:
> https://searchfox.org/mozilla-central/rev/36dec78aecc40539ecc8d78e91612e38810f963c/toolkit/components/extensions/ProxyScriptContext.jsm#361
>   * Messenger:
> https://searchfox.org/mozilla-central/rev/36dec78aecc40539ecc8d78e91612e38810f963c/toolkit/components/extensions/ProxyScriptContext.jsm#508

If this old proxy API is removed, then the proxy script context disappears too, and then the main process does not have recipients for extension messages, except for native messaging and embedded WebExtensions (which are currently already handled separately).

This may change when the internals of extension messaging is refactored by Kris.

Comment 7

[Shane Caraveo (:mixedpuppy)]

Ok, a comment for the see also would have been helpful.

Comment 8

[Shane Caraveo (:mixedpuppy)]

FYI one option is to get this to work in its own thread.  Then we could actually implement the full PAC api, including synchronous dns.  In that case, we wouldn't deprecate this api.  Supporting multiple PAC scripts would be useful for organizations that rely on them.  I haven't really looked into it, not sure how much effort it is.

Comment 9

[signfinder]

This bug is preventing the operation with switching of proxy servers by extensions in Firefox.
Can someone pay attention to it.
Thanks.

Comment 10

[Rob Wu [:robwu]]

(In reply to signfinder from comment #9)

This bug is preventing the operation with switching of proxy servers by extensions in Firefox.
Can someone pay attention to it.
Thanks.

How would this bug prevent you from doing that? This bug is about removing a feature, not about adding something new.

Comment 11

[Mike Conca [:mconca]]

Changing to a more accurate title.

Target is Firefox 71.

Comment 12

[Salar]

Can you read my #3 comment in here please
https://bugzilla.mozilla.org/show_bug.cgi?id=1545811#c3
Not reposting it here.

Comment 14

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1443259 remove deprecated proxy APIs

Comment 15

[Shane Caraveo (:mixedpuppy)]

In addition to removing register/onregister/onProxyError from proxy docs: need to delete toProxyScript from https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/runtime/sendMessage

Comment 16

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1099b5b6ea371c14c3bb0ab387cbaf11b2364e36

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5ccb3bf4c1b
remove deprecated proxy APIs r=robwu

Comment 18

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d5ccb3bf4c1b

Comment 19

[Alex Cornestean]

Hello,

Will this require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!

Comment 20

[Shane Caraveo (:mixedpuppy)]

This is code removal and the remaining APIs have tests and have existed for a long time now.

Comment 21

[Chris Mills [:cmills]]

Looks like we've done the docs for this one; see https://github.com/mdn/sprints/issues/2278