Remove proxy.register/unregister

NEW
Unassigned

Status

enhancement
P2
normal
a year ago
7 days ago

People

(Reporter: mixedpuppy, Unassigned)

Tracking

(Blocks 2 bugs)

58 Branch
Future
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

()

Reporter

Description

a year ago
The initial proxy api created a pseudo-pac script since the proxy filter system was synchronous at that stage.  It never implemented the PAC APIs (partly due to a requirement for synchronous DNS in them), so normal in-the-wild PAC scripts will not work with this.  Now that an asynchronous api has landed, we should deprecate the old stuff and get it removed eventually.
Reporter

Updated

a year ago
Duplicate of this bug: 1319630
Reporter

Updated

a year ago
Duplicate of this bug: 1319631
Reporter

Updated

a year ago
Duplicate of this bug: 1396485
Reporter

Updated

a year ago
Duplicate of this bug: 1319634

Updated

a year ago
See Also: → 1456786
Reporter

Comment 5

a year ago
bug 1456786 is unrelated to the proxy api.
See Also: 1456786

Comment 6

a year ago
FYI: bug 1456786 contains one note that is relevant to the proxy.register API:

> The only reason for subscribing to messages on the parent process manager is:
> - ProxyScriptContext
>   * context.messageManager = cpmm:
> https://searchfox.org/mozilla-central/rev/36dec78aecc40539ecc8d78e91612e38810f963c/toolkit/components/extensions/ProxyScriptContext.jsm#361
>   * Messenger:
> https://searchfox.org/mozilla-central/rev/36dec78aecc40539ecc8d78e91612e38810f963c/toolkit/components/extensions/ProxyScriptContext.jsm#508

If this old proxy API is removed, then the proxy script context disappears too, and then the main process does not have recipients for extension messages, except for native messaging and embedded WebExtensions (which are currently already handled separately).

This may change when the internals of extension messaging is refactored by Kris.
Reporter

Comment 7

a year ago
Ok, a comment for the see also would have been helpful.
See Also: → 1456786
Reporter

Comment 8

a year ago
FYI one option is to get this to work in its own thread.  Then we could actually implement the full PAC api, including synchronous dns.  In that case, we wouldn't deprecate this api.  Supporting multiple PAC scripts would be useful for organizations that rely on them.  I haven't really looked into it, not sure how much effort it is.

Updated

11 months ago
Product: Toolkit → WebExtensions
Reporter

Updated

6 months ago
Priority: P3 → P2

Comment 9

2 months ago

This bug is preventing the operation with switching of proxy servers by extensions in Firefox.
Can someone pay attention to it.
Thanks.

Comment 10

2 months ago

(In reply to signfinder from comment #9)

This bug is preventing the operation with switching of proxy servers by extensions in Firefox.
Can someone pay attention to it.
Thanks.

How would this bug prevent you from doing that? This bug is about removing a feature, not about adding something new.

Blocks: 1545811

Changing to a more accurate title.

Target is Firefox 71.

Summary: deprecate proxy.register/unregister → Remove proxy.register/unregister
Target Milestone: --- → Future

Comment 12

7 days ago

Can you read my #3 comment in here please
https://bugzilla.mozilla.org/show_bug.cgi?id=1545811#c3
Not reposting it here.

You need to log in before you can comment on or make changes to this bug.