1545811 - [meta] Deprecate old proxy API

Status: RESOLVED FIXED

(WebExtensions :: General, task, P1)

Description

[Mike Conca [:mconca]]

Meta bug to track all steps necessary to deprecate the following WebExtensions API:

• proxy.register
• proxy.unregister
• proxy.onProxyError

This change is being announced in the Firefox 68 nightly cycle. Per the deprecation policy, the APIs listed above will cease to function in Firefox 71. Developers should instead listen to the proxy.onRequest event.

Comment 1

[Mike Conca [:mconca]]

Linter warning for web-ext and AMO is tracked here:
https://github.com/mozilla/addons-linter/issues/2556

Comment 2

[Mike Conca [:mconca]]

MDN documentation update is tracked here:
https://github.com/mdn/sprints/issues/1364

Comment 3

[Salar]

Question:
As stated in web​Request​.Request​Filter doc page "Only requests made using HTTP or HTTPS will trigger events". So what about other protocols e.g. FTP ?
PAC script supports FTP and other protocols.
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/webRequest/RequestFilter

I'm the developer of SmartProxy extension and I am confirming this behaviour. I think the deprecation schedule should be delayed until this problem is solved.

Comment 4

[Shane Caraveo (:mixedpuppy)]

I've verified the ftp issue and created Bug 1552248. We're not going to delay the schedule, we have time to get a fix in well before 71.

Comment 5

[Shane Caraveo (:mixedpuppy)]

Salar, are you actually using proxy.register? Or are you using proxy.settings to set a PAC script?

Comment 6

[Shane Caraveo (:mixedpuppy)]

(In reply to Shane Caraveo (:mixedpuppy) from comment #5)

Salar, are you actually using proxy.register? Or are you using proxy.settings to set a PAC script?

I'm assuming proxy.settings otherwise it wouldn't have worked starting in fx67. Bug 1525447

Comment 7

[Salar]

I'm using all three APIs.
proxy.onRequest for HTTP/HTTPS
proxy.register for FTP
proxy.settings for setting the browser to use system proxy. Which unfortunately doesn't work in FF beta version (because of #1525447 ?) I mean proxy.settings fails to set the settings for normal session unless user allows the extension for incognito.

I'm more than happy proxy.register to be removed but I need to get the FTP support in other api first.

Comment 8

[Irene Smith]

The two functions and the proxy page all have the added information that these function are deprecated. Now I've added the following note to the Firefox 68 release notes:

The The proxy.register() and proxy.unregister() functions have been deprecated and will be removed from Firefox 71 (bug 1545811).

I will note that the functions have been removed in the Firefox 71 release notes.

Comment 9

[Rustam]

(In reply to Shane Caraveo (:mixedpuppy) from comment #6)

(In reply to Shane Caraveo (:mixedpuppy) from comment #5)

Salar, are you actually using proxy.register? Or are you using proxy.settings to set a PAC script?

I'm assuming proxy.settings otherwise it wouldn't have worked starting in fx67. Bug 1525447

Hi. What's the difference between proxy.onRequest and proxy​.settings in terms of user's security?
How IP address (proxy​.Request​Details.ip) is resolved when proxy.onRequest is fired?
Do I understand correctly that even if I set proxy using proxy.onRequest, the browser will resolve IP address for each domain using default system resolver?

Comment 10

[Shane Caraveo (:mixedpuppy)]

dependencies are resolved.