Closed Bug 1388676 Opened 3 years ago Closed 2 years ago

[meta] Implement Photon bookmarks toolbar style

Categories

(Firefox :: Theme, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: johannh, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: meta)

Attachments

(1 obsolete file)

+++ This bug was initially created as a clone of Bug #1369415 +++

Spec is here: https://mozilla.invisionapp.com/share/MRBK1MZF7#/screens/237332831
Comment on attachment 8895302 [details]
Bug 1388676 - Consolidate bookmark toolbar styling across platforms to the new Photon design.

https://reviewboard.mozilla.org/r/166498/#review171646

See bug 1369415 comment 22 and my note from irc wrt to the spacing issue: we should properly explain and document such changes, if not out of respect for the community then for archeological purposes. Otherwise the next dev will come along not understanding the change and either revert without knowing the whole story, or be afraid to touch it at all, when instead we should enable them to make an informed decision.

I see no upside to lumping all these changes into a single patch. Breaking this up and properly explaining it is easy enough and not a waste of time.
Attachment #8895302 - Flags: review?(dao+bmo)
No longer blocks: 1369415
No longer depends on: 1388529
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [photon-visual][triage] → [photon-visual]
Depends on: 1388699
Depends on: 1388700
Sorry for the noise, I filed bug 1388699 and bug 1388700 for the remaining missing pieces.
Assignee: jhofmann → nobody
Status: ASSIGNED → NEW
Iteration: 57.1 - Aug 15 → ---
Flags: qe-verify?
Keywords: meta
OS: Windows → All
Priority: P1 → --
Summary: Implement Photon bookmarks toolbar style → [meta] Implement Photon bookmarks toolbar style
Whiteboard: [photon-visual]
Attachment #8895302 - Attachment is obsolete: true
I believe there should be also a separate bug for a compact mode bookmarks toolbar.
(In reply to Eddward from comment #5)
> I believe there should be also a separate bug for a compact mode bookmarks
> toolbar.

Well spotted. We can take care of this in bug 1388700.
Yes, bug 1388700 should be about toolbar items density, but I'm also talking about bookmarks toolbar itself. Currently in Compact mode it is still too thick. As per Mockup should be 4px (I think) less height. Don't see a bug covering this. Probably similar, but opposite issue will be with a Touch mode.
See: https://s2.postimg.org/4eia9upbt/compact_bookmark_toolbar.png
Depends on: 1388794
Depends on: 1390851
Depends on: 1391593
Priority: -- → P3
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Depends on: 1402075
You need to log in before you can comment on or make changes to this bug.