1388700 - Increase horizontal margin/padding of bookmarks toolbar items

Status: VERIFIED FIXED

(Firefox :: Theme, enhancement, P1)

Description

[Dão Gottwald [:dao]]

Spec: https://mozilla.invisionapp.com/share/MRBK1MZF7#/screens/237332831

This means that fewer items will fit on the toolbar, which has previously pissed off users. Stephen is aware of that but said we should still make the change to visually separate the items better.

Comment 1

[Dão Gottwald [:dao]]

This will need to take compact mode into account, which should also be an adequate solution for users who are sensitive to fewer items fitting on the toolbar.

Comment 2

[Johann Hofmann [:johannh]]

Attachment: Bug 1388700 - Increase margin/padding of bookmarks toolbar items per Photon spec.

Review commit: https://reviewboard.mozilla.org/r/168726/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168726/

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8897415 [details]
Bug 1388700 - Increase margin/padding of bookmarks toolbar items per Photon spec.

https://reviewboard.mozilla.org/r/168726/#review174454

The spec calls for 8px of padding at the start of the toolbar - currently there's only 4px. (And maybe we want to reduce this padding in compact mode?)

Comment 4

[Dão Gottwald [:dao]]

(In reply to Nihanth Subramanya [:nhnt11] from comment #3)
> Comment on attachment 8897415 [details]
> Bug 1388700 - Increase margin/padding of bookmarks toolbar items per Photon
> spec.
> 
> https://reviewboard.mozilla.org/r/168726/#review174454
> 
> The spec calls for 8px of padding at the start of the toolbar - currently
> there's only 4px.

That's bug 1388699.

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8897415 [details]
Bug 1388700 - Increase margin/padding of bookmarks toolbar items per Photon spec.

https://reviewboard.mozilla.org/r/168726/#review174460

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41d701ddc958
Increase margin/padding of bookmarks toolbar items per Photon spec. r=nhnt11

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/41d701ddc958

Comment 9

[Anika Alam Raha]

I have reproduced this issue with nightly 57.0a1 (2017-08-09) on Windows 8, 64-bit.

Now seeing the Increased horizontal margin/padding of bookmarks toolbar items on latest nightly.


Build ID 	20170820100343
User Agent 	Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

[bugday-20170816]