1389211 - Update pdf.js to version 1.8.618

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, task)

Description

[Ryan VanderMeulen [:RyanVM]]

+++ This bug was initially created as a clone of Bug #1387412 +++

Changes since last update:
#8746 More robust getPage() error handling.
#8752 ES6-ify the code in `web/dom_events.js`
#8756 Remove leftover `args[0].code` checks from the `OPS.paintXObject` cases in evaluator.js
#8761 Fallback to plain object for globalScope.
#8762 Replace the `coded` property with `isType3Font` when building the font `properties` object in `PartialEvaluator.translateFont`
#8764 Convert `DownloadManager` to an ES6 class

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c6d3689bf796
Update pdf.js to version 1.8.618. r=bdahl

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Confirmed on Try that this fixes bug 1368927 on Beta too. Will request uplift eventually.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c6d3689bf796

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Attachment: uplift request

Approval Request Comment
[Feature/Bug causing the regression]: I'd like to get this on Beta to silence a very frequent orange (bug 1368927)
[User impact if declined]: sad, sad, Ryan
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes and I ran it through Try to confirm that the oranges go away
[Needs manual test from QE? If yes, steps to reproduce]: none
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: low
[Why is the change risky/not risky?]: makes some error handling more robust
[String changes made/needed]: none

Comment 5

[Gerry Chang [:gchang]]

Comment on attachment 8896438 [details] [diff] [review]
uplift request

Update pdf.js and make Ryan happy. Beta56+. Should be in 56.0b3.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5fbb7413a6d4