1389482 - Add legal and telemetry fixes to Activity Stream (for Shield study)

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Comment 1

[Ed Lee :Mardak]

Attachment: WIP don't land

This WIP patch is the current state of exporting https://github.com/mozilla/activity-stream/compare/firefox-56b1...firefox-56 for k88hudson's reference.

She'll update with an actual patch that has the remaining items still waiting to land:
https://github.com/mozilla/activity-stream/labels/Release%20%2F%20Blocking

Comment 2

[Kate Hudson :k88hudson]

Attachment: Bug 1389482 - Add legal and telemetry fixes to Activity Stream

Review commit: https://reviewboard.mozilla.org/r/169174/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169174/

Comment 3

[Kate Hudson :k88hudson]

Comment on attachment 8897899 [details]
Bug 1389482 - Add legal and telemetry fixes to Activity Stream

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169174/diff/1-2/

Comment 4

[Ursula Sarracini (:ursula)]

Comment on attachment 8897899 [details]
Bug 1389482 - Add legal and telemetry fixes to Activity Stream

https://reviewboard.mozilla.org/r/169174/#review174586

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c416d136f274
Add legal and telemetry fixes to Activity Stream r=ursula

Comment 6

[Kate Hudson :k88hudson]

Comment on attachment 8897899 [details]
Bug 1389482 - Add legal and telemetry fixes to Activity Stream

Approval Request Comment
[Feature/Bug causing the regression]: Critical telemetry for pocket was missing data, legal required us to remove certain icons and replace with screenshots.
[User impact if declined]: We can't ship our shield study which is critical for getting data in preparation for the 57 release
[Is this code covered by automated tests?]: Yes, tests are included in the Activity Stream repository
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: None, all changes are self-contained
[Is the change risky?]: No
[Why is the change risky/not risky?]: Activity stream is pref'd off by default for beta users, this will affect our shield study only
[String changes made/needed]: None

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c416d136f274

Comment 8

[Liz Henry (:lizzard)]

Comment on attachment 8897899 [details]
Bug 1389482 - Add legal and telemetry fixes to Activity Stream

Fix we need for a shield study.

Comment 9

[Liz Henry (:lizzard)]

We may not be able to land this for the beta 4 build.  If we do land this for a 2nd beta 4 build this afternoon I'll let you know.  Otherwise I think it is best to delay the shield study till next Tuesday for beta 5.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e531ebf93d7b

Comment 11

[Cornel Ionce [:noni]]

(In reply to Kate Hudson :k88hudson from comment #6)
> [Is this code covered by automated tests?]: Yes, tests are included in the
> Activity Stream repository
> [Needs manual test from QE? If yes, steps to reproduce]: no

Based on Kate's assessment on manual testing needs and due to the fact that it has automated coverage, marking as qe-verify-.