Closed
Bug 1389482
Opened 7 years ago
Closed 7 years ago
Add legal and telemetry fixes to Activity Stream (for Shield study)
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
Firefox 57
People
(Reporter: Mardak, Assigned: k88hudson)
References
Details
(Whiteboard: [export])
User Story
Attachments
(2 files)
57.05 KB,
patch
|
Details | Diff | Splinter Review | |
59 bytes,
text/x-review-board-request
|
ursula
:
review+
lizzard
:
approval-mozilla-beta+
|
Details |
No description provided.
Reporter | ||
Comment 1•7 years ago
|
||
This WIP patch is the current state of exporting https://github.com/mozilla/activity-stream/compare/firefox-56b1...firefox-56 for k88hudson's reference. She'll update with an actual patch that has the remaining items still waiting to land: https://github.com/mozilla/activity-stream/labels/Release%20%2F%20Blocking
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → khudson
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8897899 -
Flags: review?(usarracini)
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8897899 [details] Bug 1389482 - Add legal and telemetry fixes to Activity Stream https://reviewboard.mozilla.org/r/169174/#review174586 Thanks!
Attachment #8897899 -
Flags: review?(usarracini) → review+
Pushed by khudson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c416d136f274 Add legal and telemetry fixes to Activity Stream r=ursula
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8897899 [details] Bug 1389482 - Add legal and telemetry fixes to Activity Stream Approval Request Comment [Feature/Bug causing the regression]: Critical telemetry for pocket was missing data, legal required us to remove certain icons and replace with screenshots. [User impact if declined]: We can't ship our shield study which is critical for getting data in preparation for the 57 release [Is this code covered by automated tests?]: Yes, tests are included in the Activity Stream repository [Has the fix been verified in Nightly?]: yes [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: None, all changes are self-contained [Is the change risky?]: No [Why is the change risky/not risky?]: Activity stream is pref'd off by default for beta users, this will affect our shield study only [String changes made/needed]: None
Attachment #8897899 -
Flags: approval-mozilla-beta?
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c416d136f274
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
status-firefox56:
--- → affected
Comment 8•7 years ago
|
||
Comment on attachment 8897899 [details] Bug 1389482 - Add legal and telemetry fixes to Activity Stream Fix we need for a shield study.
Attachment #8897899 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 9•7 years ago
|
||
We may not be able to land this for the beta 4 build. If we do land this for a 2nd beta 4 build this afternoon I'll let you know. Otherwise I think it is best to delay the shield study till next Tuesday for beta 5.
Comment 10•7 years ago
|
||
uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/e531ebf93d7b
Reporter | ||
Updated•7 years ago
|
User Story: (updated)
Comment 11•7 years ago
|
||
(In reply to Kate Hudson :k88hudson from comment #6) > [Is this code covered by automated tests?]: Yes, tests are included in the > Activity Stream repository > [Needs manual test from QE? If yes, steps to reproduce]: no Based on Kate's assessment on manual testing needs and due to the fact that it has automated coverage, marking as qe-verify-.
Flags: qe-verify-
Reporter | ||
Updated•6 years ago
|
Whiteboard: [export]
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•