1386737 - Fix broken top sites with pinned links lacking title for Activity Stream

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1386737 - Fix broken top sites with pinned links lacking title for Activity Stream.

Review commit: https://reviewboard.mozilla.org/r/163994/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163994/

Comment 2

[Ursula Sarracini (:ursula)]

Comment on attachment 8892993 [details]
Bug 1386737 - Fix broken top sites with pinned links lacking title for Activity Stream.

https://reviewboard.mozilla.org/r/163994/#review169304

Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b6833ad8ed9
Fix broken top sites with pinned links lacking title for Activity Stream. r=ursula

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5b6833ad8ed9

Comment 5

[Ed Lee :Mardak]

Comment on attachment 8892993 [details]
Bug 1386737 - Fix broken top sites with pinned links lacking title for Activity Stream.

Approval Request Comment (part 6 of 6 Mardak will uplift)
[Feature/Bug causing the regression]: Activity Stream preffed off in 56 to be enabled in Shield study
[User impact if declined]: Users could miss seeing top sites if they have unexpectedly formatted pinned sites
[Is this code covered by automated tests?]: Yes, Activity Stream has 100% line coverage
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Bug 1385716 Bug 1386265 Bug 1386350 Bug 1385090 Bug 1386314
[Is the change risky?]: No
[Why is the change risky/not risky?]: The feature is preffed off
[String changes made/needed]: Localized strings were added

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8892993 [details]
Bug 1386737 - Fix broken top sites with pinned links lacking title for Activity Stream.

Another small fix for Activity Stream for 56 beta 1.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/842b7649ba33

Comment 8

[Andrei Vaida [:avaida]]

(In reply to Ed Lee :Mardak from comment #5)
> [Is this code covered by automated tests?]: Yes, Activity Stream has 100%
> line coverage
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: No

Setting qe-verify- based on Ed Lee's assessment on manual testing needs and the fact that this fix has automated coverage.

Comment 9

[Aki Sasaki (not active)]

https://hg.mozilla.org/projects/date/rev/5b6833ad8ed993eca8bb4fcbb4668c2a2f3c2d95
Bug 1386737 - Fix broken top sites with pinned links lacking title for Activity Stream. r=ursula