Closed Bug 1386737 Opened 2 years ago Closed 2 years ago

Fix broken top sites with pinned links lacking title for Activity Stream

Categories

(Firefox :: New Tab Page, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

User Story

https://github.com/mozilla/activity-stream/compare/44ba8561d895a7defcf08d46d877a4d239395ecb...firefox-56b1

Attachments

(1 file)

No description provided.
Comment on attachment 8892993 [details]
Bug 1386737 - Fix broken top sites with pinned links lacking title for Activity Stream.

https://reviewboard.mozilla.org/r/163994/#review169304

Thanks!
Attachment #8892993 - Flags: review?(usarracini) → review+
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5b6833ad8ed9
Fix broken top sites with pinned links lacking title for Activity Stream. r=ursula
Blocks: 1386785
https://hg.mozilla.org/mozilla-central/rev/5b6833ad8ed9
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment on attachment 8892993 [details]
Bug 1386737 - Fix broken top sites with pinned links lacking title for Activity Stream.

Approval Request Comment (part 6 of 6 Mardak will uplift)
[Feature/Bug causing the regression]: Activity Stream preffed off in 56 to be enabled in Shield study
[User impact if declined]: Users could miss seeing top sites if they have unexpectedly formatted pinned sites
[Is this code covered by automated tests?]: Yes, Activity Stream has 100% line coverage
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Bug 1385716 Bug 1386265 Bug 1386350 Bug 1385090 Bug 1386314
[Is the change risky?]: No
[Why is the change risky/not risky?]: The feature is preffed off
[String changes made/needed]: Localized strings were added
Attachment #8892993 - Flags: approval-mozilla-beta?
Comment on attachment 8892993 [details]
Bug 1386737 - Fix broken top sites with pinned links lacking title for Activity Stream.

Another small fix for Activity Stream for 56 beta 1.
Attachment #8892993 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Assignee: nobody → edilee
Blocks: 1387746
(In reply to Ed Lee :Mardak from comment #5)
> [Is this code covered by automated tests?]: Yes, Activity Stream has 100%
> line coverage
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: No

Setting qe-verify- based on Ed Lee's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
https://hg.mozilla.org/projects/date/rev/5b6833ad8ed993eca8bb4fcbb4668c2a2f3c2d95
Bug 1386737 - Fix broken top sites with pinned links lacking title for Activity Stream. r=ursula
User Story: (updated)
Blocks: 1389482
No longer blocks: 1387746
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.