1390828 - Form Autofill Preferences - Saved Addresses modal shows unnecessary scrollbars

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect, P3)

Description

[Albert Scheiner [:alberts]]

Attachment: prefs-autofil-addresses-scrollbar.png

There is a horizontal and a vertical scrollbar outside of the area that should actually be scrollable. They clearly shouldn't be there and making it a bit hard to use the modal.

Comment 1

[Matthew N. [:MattN]]

What build was this in?

Scott, I think you were adjusting some of the layouts to avoid clipping, do you have an existing bug on fixing this?

Comment 2

[Luke Chang [:lchang] (inactive)]

Looks like we had bug 1385813 for edit dialog only.

Comment 3

[Albert Scheiner [:alberts]]

Attachment: prefs-autofil-addresses-scrollbar_2.png

Just checked again with build ID 20170816100153, and it seems to be partly fixed. I now get only a horizontal scrollbar, which is invisible in macOS until you actually try scrolling to the left. New image attached.

(!) Actually, had a second look and resized the window to the smallest possible size (which only changed it by 1-2 pixel in height) and got both scrollbars back.

Comment 4

[Scott Wu [:scottwu]]

I think it's caused by changes in preferences stylesheets. The layout in edit address dialog is affected too (filed bug 1391148). Will look into this after I finish working on credit card preferences. Thanks for filing this bug.

Comment 5

[Scott Wu [:scottwu]]

Attachment: Bug 1390828 - Fix addresses and credit cards list margin and height issues.

Review commit: https://reviewboard.mozilla.org/r/173200/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173200/

Comment 7

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8901764 [details]
Bug 1390828 - Fix addresses and credit cards list margin and height issues.

https://reviewboard.mozilla.org/r/173200/#review178842

Comment 8

[Scott Wu [:scottwu]]

Thanks Luke. Checking it in.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f516952da0d4
Fix addresses and credit cards list margin and height issues. r=lchang

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f516952da0d4

Comment 11

[Matthew N. [:MattN]]

Comment on attachment 8901764 [details]
Bug 1390828 - Fix addresses and credit cards list margin and height issues.

Approval Request Comment
[Feature/Bug causing the regression]: autofill profile list dialog
[User impact if declined]: unnecessary scrollbars making UI look unpolished
[Is this code covered by automated tests?]: Yes, but not specifically for visual polish
[Has the fix been verified in Nightly?]: Yes, I don't see the problem in Nightly
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: small CSS changes only and it has baked for a while
[String changes made/needed]:

Comment 12

[Matthew N. [:MattN]]

Comment on attachment 8901764 [details]
Bug 1390828 - Fix addresses and credit cards list margin and height issues.

Nevermind, this should have been marked as unaffected since I think it due to preferences changes