Closed Bug 1390849 Opened 2 years ago Closed 2 years ago

Port bug 1386176 to TB [Provide value in update url to indicate whether a Firefox 32 bit install hasn't been migrated to Firefox 64 bit previously]

Categories

(Thunderbird :: Installer, enhancement)

x86_64
Windows
enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 57.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

In bug 1386176 FX provides a installer macro to migrate FX from 32 bit to 64 bit. We can implement it to easily follow FX installer changes, but disable the macro call until we are ready to enable the migration.
Attached patch migrate32bitTo64bit.patch (obsolete) — Splinter Review
For our Mr. installer reviewer. ;-)

The FX changes are here: https://hg.mozilla.org/mozilla-central/rev/09f9d9c51836
Attachment #8897835 - Flags: review?(jorgk)
Comment on attachment 8897835 [details] [diff] [review]
migrate32bitTo64bit.patch

Review of attachment 8897835 [details] [diff] [review]:
-----------------------------------------------------------------

You know how I love installer reviews, so I saved the best for last ;-)

This looks like a straight port. r=jorgk with one nit fixed. I can change the comment upon checkin, or you can do it now.

Sorry to be picky. And thank you so much, as always, for keeping Thunderbird up-to-date with movements in Firefox since this is essential for the survival of Thunderbird. Whilst your work is done silently and mostly invisibly, it is very important and a fantastic help and tremendous contribution to the project.

::: mail/installer/windows/nsis/installer.nsi
@@ +380,5 @@
>      ${UpdateProtocolHandlers}
>    ${EndIf}
>  
>    ${RemoveDeprecatedKeys}
> +  ; This macro is disabled until we are ready for the 32bit > 64bit migration.

This comment is confusing. In fact, the macro is not disabled, since you implement it in shared.nsh.

For the moment we just don't call it. I also dislike mixing English with mathematical symbols. So please change the comment here and in the other file to:

; The following macro call is disabled until we are ready for the 32bit to 64bit migration.
Attachment #8897835 - Flags: review?(jorgk) → review+
Thanks.

Updated the comments as requested.
Attachment #8897835 - Attachment is obsolete: true
Attachment #8899118 - Flags: review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/fdd630e5671e
Port bug 1386176 to TB [Provide value in update url to indicate whether a Firefox 32 bit install hasn't been migrated to Firefox 64 bit previously]. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 57.0
Cool that it is fixed!

But where is it?  No sign of it over on 
http://ftp.mozilla.org/pub/thunderbird/releases/52.3.0/
(In reply to Todd from comment #5)
> Cool that it is fixed!
> 
> But where is it?  No sign of it over on 

This is only a preparation. 64bit exists now only for Daily. It will be enabled with bug 1390850. But first we need the 64bit environment for beta and release. Until then there will be no 64bit TB.
You need to log in before you can comment on or make changes to this bug.