Closed Bug 1390850 (Enable-32bit-to-64bit-migration) Opened 3 years ago Closed 1 year ago

Enable the 32 bit to 64 bit migration for Thunderbird.

Categories

(Thunderbird :: Installer, enhancement)

x86_64
Windows
enhancement
Not set
normal

Tracking

(thunderbird_esr6068+ fixed, thunderbird68+ fixed, thunderbird69 fixed)

RESOLVED FIXED
Thunderbird 69.0
Tracking Status
thunderbird_esr60 68+ fixed
thunderbird68 + fixed
thunderbird69 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

When everything is ready to migrate 32 bit TB to 64 bit (build infrastructure, tests, no remaining blockers etc.), we can enable by uncommenting the call to the 'Set32to64DidMigrateReg' macro in installer.nsi and shared.nsh.
Personal experience: I just migrated from 32bit to 64bit on Windows10-1803 without any problems.

Beside the 32bit i already had, i installed the 64bit side by side with it (default options). 
I opened the 64bit after install to check if everything was there. Once i saw it was i removed the 32bit. 

Worked without any problems.
(In reply to Maverick from comment #1)
> Personal experience: I just migrated from 32bit to 64bit on Windows10-1803
> without any problems.
> 
> Beside the 32bit i already had, i installed the 64bit side by side with it
> (default options). 
> I opened the 64bit after install to check if everything was there. Once i
> saw it was i removed the 32bit. 
> 
> Worked without any problems.

I saw in another bug a reference to doing this in the Fall.  Let's get this done.
not happening for beta 61, which in fact is long past several months ago.  You can check via bug 634233 that there is more work to be done, and no one is predicting when that work will happen.
It looks like the only dependency is bug 393302. 

Since beta 61 is "long past", please select the cycle after that, then.

I have just updated bug 634233 suggesting that maybe this bug doesn't block bug 634233, so ...

(In reply to Richard Marti (:Paenglab) from comment #0)

... uncommenting 'Set32to64DidMigrateReg' macro in installer.nsi and shared.nsh.

Richard, what exactly does this change do?

Flags: needinfo?(richard.marti)

It enables the removal of 32bit registry keys, see https://searchfox.org/mozilla-central/source/browser/installer/windows/nsis/shared.nsh#559-562

We should enable this when we support 64bit officially and the user don't need to go back to 32bit for an official build.

Flags: needinfo?(richard.marti)

Any difference in execution/results between user who updates a 32bit system vs a user who downloads a 64bit install?

Flags: needinfo?(richard.marti)

From the comment in shared.nsh where should be no difference.

But better ask an expert. Robert, Set32to64DidMigrateReg is executed on install and update. Is that correct?

Flags: needinfo?(richard.marti) → needinfo?(robert.strong.bugs)

(In reply to Richard Marti (:Paenglab) from comment #8)

From the comment in shared.nsh where should be no difference.

But better ask an expert. Robert, Set32to64DidMigrateReg is executed on install and update. Is that correct?

It is
https://searchfox.org/mozilla-central/source/browser/installer/windows/nsis/installer.nsi#404
https://searchfox.org/mozilla-central/source/browser/installer/windows/nsis/shared.nsh#100

BTW: I no longer work on installer code.

I'm planning on removing the one-off support for 32 to 64 bit migration in app update when I get a chance. I can hold off a few releases though it has been over a year and a half since that code was added. When is this going to happen?

Flags: needinfo?(robert.strong.bugs)

(In reply to Robert Strong (Robert they/them) [:rstrong] (use needinfo to contact me) from comment #9)

I'm planning on removing the one-off support for 32 to 64 bit migration in app update when I get a chance. I can hold off a few releases though it has been over a year and a half since that code was added. When is this going to happen?

If all goes well, we enable it for 68. We have the code copied in our shared.nsh on c-c. Removing it in /browser shouldn't affect us and we can remove it later in our code.

OK... I'll hold off removal in /toolkit/mozapps/update/ until 69 or 70.

As discussed with Magnus in my weekly meeting, can we do what's required here (and ignore bug 1509918 for the time being).

Flags: needinfo?(richard.marti)

This patch enables the 32bit to 64bit registration migration.

What is needed, is on server side that instead of the 32bit- the 64bit installer/update is sent to the user when his OS is 64bit capable.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Flags: needinfo?(richard.marti)
Attachment #9069427 - Flags: review?(jorgk)
Comment on attachment 9069427 [details] [diff] [review]
1390850-enable 32to64bit-migration.patch

Thanks, not too hard then.
Attachment #9069427 - Flags: review?(jorgk) → review+

(In reply to Richard Marti (:Paenglab) from comment #13)

What is needed, is on server side that instead of the 32bit- the 64bit installer/update is sent to the user when his OS is 64bit capable.

Rob, can you take care of this.

Flags: needinfo?(rob)
Keywords: checkin-needed
Attachment #9069427 - Flags: approval-comm-beta+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/ae833bff1165
Enable the 32 bit to 64 bit migration for Thunderbird. r=jorgk

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 69.0

The process Firefox used server-side is documented in bug 1393447, I'll open a new bug for us and attach it to the metabug so it can be tracked.

Flags: needinfo?(rob)

(In reply to Rob Lemley [:rjl] from comment #18)

The process Firefox used server-side is documented in bug 1393447, I'll open a new bug for us and attach it to the metabug so it can be tracked.

Please link here also. Thank you.

Depends on: 1556748

Wait. The title of this bug is "Enable the 32 bit to 64 bit migration for Thunderbird.", and its status is fixed.

Does this mean it will start working automatically? On which versions?

This just enables the registry setting to allow a future migration.

Maybe the title should be changed to better reflect this.

Attachment #9069427 - Flags: approval-comm-esr60?
Attachment #9069427 - Flags: approval-comm-esr60? → approval-comm-esr60+
You need to log in before you can comment on or make changes to this bug.