1390951 - stylo: Crash in style::stylesheet_set::StylesheetSet<T>::collect_invalidations_for<T>

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-ca52c7f2-93fa-453a-87e9-715db0170815.
=============================================================

Seen while looking at crash stats: http://bit.ly/2fLMPEx. 8 crashes/8 installations. Crashes started using 

crash reason in one report: Moz crash reason: Locked::read_with called with a guard from an unrelated SharedRwLock

URL shows as about:printpreview

Comment 1

[Emilio Cobos Álvarez (:emilio) (PTO until Jul 10)]

(In reply to Marcia Knous [:marcia - use ni] from comment #0)
> crash reason in one report: Moz crash reason: Locked::read_with called with
> a guard from an unrelated SharedRwLock

This one report needs to be corrupted memory of some sort, we only use a single SharedRwLock, so...

Comment 2

[Chris Peterson [:cpeterson]]

I don't see any crash reports from Beta 56 yet.

Comment 3

[Chris Peterson [:cpeterson]]

Over the past week, there have been 56 instances of this crash signature from 26 different users.

Comment 4

[Emilio Cobos Álvarez (:emilio) (PTO until Jul 10)]

A _lot_ of them are print preview related... Do we have any reproducible print preview issue? Any url in those bugs?

Comment 5

[Chris Peterson [:cpeterson]]

Nearly all of the crashes are from Windows, mostly with URL about:printpreview. 3 of the 4 Linux crashes have the following URL:

https://www.howtogeek.com/240487/how-to-play-dvds-and-blu-rays-on-linux/

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

I suspect this kind of crash may be because of mix of gecko sheet and servo sheet. There may be other cases that we haven't solved to have both Servo and Gecko stylesheet on the same page somehow.

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

Still seems to happen many times. Given that print preview isn't that a frequently used feature, the crash rate seems high enough... It would be good if we can have a reproducible case.

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

(I tried with several websites, and failed to reproduce this crash... I hit bug 1394630 several times, but when I use the same page in release build, no crash happens.)

Comment 9

[Bobby Holley (:bholley)]

I can reproduce some crashes on print preview using the URL in comment 5.

Comment 10

[Bobby Holley (:bholley)]

Attachment: Use the same style backend when cloning documents. v1

MozReview-Commit-ID: F6HMAsSsNDa

Comment 11

[Bobby Holley (:bholley)]

Attachment: Assert harder against stylesheet type mismatches. v1

MozReview-Commit-ID: 1oB7FDxAZFt

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3fe2012dd403
Use the same style backend when cloning documents. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/f2998d03afcc
Assert harder against stylesheet type mismatches. r=xidorn

Comment 13

[Chris Peterson [:cpeterson]]

I see one instance of this crash on Beta 56. If we see any more and this patch fixes the problem on Nightly, we should consider uplifting to Beta 56.

Comment 14

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3fe2012dd403
https://hg.mozilla.org/mozilla-central/rev/f2998d03afcc