Closed
Bug 1390951
Opened 6 years ago
Closed 6 years ago
stylo: Crash in style::stylesheet_set::StylesheetSet<T>::collect_invalidations_for<T>
Categories
(Core :: CSS Parsing and Computation, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | wontfix |
firefox57 | --- | fixed |
People
(Reporter: marcia, Assigned: bholley)
References
Details
(Keywords: crash)
Crash Data
Attachments
(2 files)
1.07 KB,
patch
|
xidorn
:
review+
|
Details | Diff | Splinter Review |
4.73 KB,
patch
|
xidorn
:
review+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-ca52c7f2-93fa-453a-87e9-715db0170815. ============================================================= Seen while looking at crash stats: http://bit.ly/2fLMPEx. 8 crashes/8 installations. Crashes started using crash reason in one report: Moz crash reason: Locked::read_with called with a guard from an unrelated SharedRwLock URL shows as about:printpreview
Updated•6 years ago
|
status-firefox55:
--- → unaffected
status-firefox56:
--- → ?
status-firefox-esr52:
--- → unaffected
Priority: -- → P3
Comment 1•6 years ago
|
||
(In reply to Marcia Knous [:marcia - use ni] from comment #0) > crash reason in one report: Moz crash reason: Locked::read_with called with > a guard from an unrelated SharedRwLock This one report needs to be corrupted memory of some sort, we only use a single SharedRwLock, so...
Comment 2•6 years ago
|
||
I don't see any crash reports from Beta 56 yet.
Comment 3•6 years ago
|
||
Over the past week, there have been 56 instances of this crash signature from 26 different users.
Comment 4•6 years ago
|
||
A _lot_ of them are print preview related... Do we have any reproducible print preview issue? Any url in those bugs?
Flags: needinfo?(cpeterson)
Comment 5•6 years ago
|
||
Nearly all of the crashes are from Windows, mostly with URL about:printpreview. 3 of the 4 Linux crashes have the following URL: https://www.howtogeek.com/240487/how-to-play-dvds-and-blu-rays-on-linux/
Flags: needinfo?(cpeterson)
Updated•6 years ago
|
OS: Windows 10 → All
Comment 6•6 years ago
|
||
I suspect this kind of crash may be because of mix of gecko sheet and servo sheet. There may be other cases that we haven't solved to have both Servo and Gecko stylesheet on the same page somehow.
Comment 7•6 years ago
|
||
Still seems to happen many times. Given that print preview isn't that a frequently used feature, the crash rate seems high enough... It would be good if we can have a reproducible case.
Priority: P3 → P2
Comment 8•6 years ago
|
||
(I tried with several websites, and failed to reproduce this crash... I hit bug 1394630 several times, but when I use the same page in release build, no crash happens.)
Assignee | ||
Comment 9•6 years ago
|
||
I can reproduce some crashes on print preview using the URL in comment 5.
Assignee: nobody → bobbyholley
Assignee | ||
Comment 10•6 years ago
|
||
MozReview-Commit-ID: F6HMAsSsNDa
Attachment #8902416 -
Flags: review?(xidorn+moz)
Assignee | ||
Comment 11•6 years ago
|
||
MozReview-Commit-ID: 1oB7FDxAZFt
Attachment #8902417 -
Flags: review?(xidorn+moz)
Updated•6 years ago
|
Attachment #8902416 -
Flags: review?(xidorn+moz) → review+
Updated•6 years ago
|
Attachment #8902417 -
Flags: review?(xidorn+moz) → review+
Comment 12•6 years ago
|
||
Pushed by bholley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3fe2012dd403 Use the same style backend when cloning documents. r=xidorn https://hg.mozilla.org/integration/autoland/rev/f2998d03afcc Assert harder against stylesheet type mismatches. r=xidorn
Comment 13•6 years ago
|
||
I see one instance of this crash on Beta 56. If we see any more and this patch fixes the problem on Nightly, we should consider uplifting to Beta 56.
![]() |
||
Comment 14•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3fe2012dd403 https://hg.mozilla.org/mozilla-central/rev/f2998d03afcc
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•6 years ago
|
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•