Closed Bug 1391467 Opened 3 years ago Closed 3 years ago

Remove --enable-necko-protocols

Categories

(Core :: Networking, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: u408661, Assigned: u408661)

References

Details

(Whiteboard: [necko-active])

Attachments

(1 file)

59 bytes, text/x-review-board-request
gps
: review+
valentin
: review+
Details
This build config option is totally broken with e10s (ipdl doesn't support ifdef, so we can't conditionally compile in protocol support there). So, let's just get rid of this build option (and all the #defines it's responsible for).
Duplicate of this bug: 1383587
Comment on attachment 8898997 [details]
Bug 1391467 - Remove --enable-necko-protocols.

https://reviewboard.mozilla.org/r/170334/#review175590

Always happy to review a patch that deletes code :)

Hopefully this is obvious, but my r+ is for the build system bits, not the C++. I also didn't look at the moz.build changes in too much detail, as we typically defer review of those to the module they relate to. But the changes seemed reasonable.
Attachment #8898997 - Flags: review?(gps) → review+
Attachment #8898997 - Flags: review?(mcmanus) → review?(valentin.gosu)
(In reply to Gregory Szorc [:gps] from comment #5)
> Comment on attachment 8898997 [details]
> Bug 1391467 - Remove --enable-necko-protocols.
> 
> https://reviewboard.mozilla.org/r/170334/#review175590
> 
> Always happy to review a patch that deletes code :)

They're my favorite patches to write! :)

> Hopefully this is obvious, but my r+ is for the build system bits, not the
> C++. I also didn't look at the moz.build changes in too much detail, as we
> typically defer review of those to the module they relate to. But the
> changes seemed reasonable.

Indeed. I originally asked mcmanus, but he's on PTO this week, and I'd like to get this landed, so redirect to valentin.
Comment on attachment 8898997 [details]
Bug 1391467 - Remove --enable-necko-protocols.

https://reviewboard.mozilla.org/r/170334/#review176030

This is some great stuff! Thanks!
Attachment #8898997 - Flags: review?(valentin.gosu) → review+
Pushed by hurley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ce6e2f914c96
Remove --enable-necko-protocols. r=gps,valentin
https://hg.mozilla.org/mozilla-central/rev/ce6e2f914c96
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.