1392929 - Port Bug 886907 - Remove old synchronous contentPrefService to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[dominique fillon]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 SeaMonkey/2.54a1 Lightning/5.9a1
Build ID: 20170822044702

Steps to reproduce:

Testing with SeaMonkey nightly (User agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 SeaMonkey/2.54a1
Build identifier: 20170822044702)
The text sizing controls are not present, not effective (Ctrl +, Ctrl -)



Actual results:

no possibility to increase / decrease font size in browser window.


Expected results:

Increase / decrease font size was still working on builds 20170813 (Win32 and Win64)

Comment 1

[dominique fillon]

The browser menu View does not show the usual Ctrl+ / Ctrl - (increase / decrease font).
Regression between 20170813 and 20170822

Comment 2

[dominique fillon]

Some more details:
- The problem is still there with add-ons disabled.
- The browser menu under "View" is partially there for CTRL+ and CTRL-, but not effective, either in normal or add-ons disabled modes.

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1392929-thisisnotafix.patch

As the comment says. Just a quick hack till Bill is ready with a patch. Unbreaks the browser but zoom handling/setting will likely be not ok because the old sync apis are still used.

Comment 7

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8903585 [details] [diff] [review]
1392929-thisisnotafix.patch

This bug breaks the browser badly. I suggest putting in the interim hacky patch till the real patch is ready. Back Forward works again with it and most fuctionality too.

Comment 8

[David Edwards]

I second that. I am using the interim patch and the only inconvenience is the lack of automatic password provision. BTW, the ancient chrome://passwordmgr/content/passwordManager.xul is infinitely more performant than the 'data manager' provided through the menus, even when this works (which it doesn't at the moment).

Comment 9

[Frank-Rainer Grahl (:frg)]

David, if you compile SeaMonkey yourself also put the patch for Bug 1394101 in and Data Manager should work again for everything but content prefs.

Comment 10

[Ian Neal]

Comment on attachment 8903585 [details] [diff] [review]
1392929-thisisnotafix.patch

r=me for the sticking plaster

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0ca324fbb106
Temporary Fix for contentPrefService removal. r=IanN

Comment 12

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8903585 [details] [diff] [review]
1392929-thisisnotafix.patch

Working to fix up 2.54 now and this would help me there too.

Comment 13

[Ian Neal]

Comment on attachment 8903585 [details] [diff] [review]
1392929-thisisnotafix.patch

a=me

Comment 14

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8903585 [details] [diff] [review]
1392929-thisisnotafix.patch

https://hg.mozilla.org/releases/comm-beta/rev/affbacc786e547237660b8277d051785c2dd3a40

Comment 15

[Ian Neal]

Attachment: 1392929-mc-contentprefs2-25315.patch

[Approval Request Comment]
Regression caused by (bug #): Bug 886907
User impact if declined: features that depend on content prefs stop working
Testing completed (on m-c, etc.): 2.53.14
Risk to taking this patch (and alternatives if risky): some
String changes made by this patch: none

Comment 16

[Ian Neal]

Attachment: 1392929-cc-contentprefs2-2515.patch

[Approval Request Comment]
Regression caused by (bug #): Bug 886907
User impact if declined: things that depend on content prefs don't work
Testing completed (on m-c, etc.): 2.53.14
Risk to taking this patch (and alternatives if risky): some
String changes made by this patch: none

Makes use of the extra code from the mozilla part.

Comment 17

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9294732 [details] [diff] [review]
1392929-mc-contentprefs2-25315.patch

Remvong a content pref in the data manager now results in:

Timestamp: 17.09.2022, 18:57:53
Error: NS_ERROR_XPC_BAD_CONVERT_JS: Could not convert JavaScript argument arg 1 [nsIContentPrefService2.hasPrefs]
Source File: chrome://communicator/content/dataman/dataman.js
Line: 1918

Timestamp: 17.09.2022, 18:57:53
Error: [Exception... "Could not convert JavaScript argument arg 1 [nsIContentPrefService2.hasPrefs]" nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)" location: "JS frame :: chrome://communicator/content/dataman/dataman.js :: prefs_reactToChange :: line 1918" data: no]

Try to fix or back out first?

Comment 18

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9294734 [details] [diff] [review]
1392929-cc-contentprefs2-2515.patch

Services.contentPrefs2.hasPrefs(null, domain != "*" ? domain : null, {

Arguments are reversed so an easy fixer.

Next one:
Timestamp: 17.09.2022, 19:44:01
Error: TypeError: Services.contentPrefs is undefined
Source File: chrome://communicator/content/pref/pref-content.js
Line: 42

Comment 19

[Ian Neal]

Attachment: 1392929-cc-contentprefs2-1_1-25315.patch

Patch with issues fixed.

Comment 20

[Ian Neal]

Comment on attachment 9294732 [details] [diff] [review]
1392929-mc-contentprefs2-25315.patch

Issues fixed in cc patch

Comment 21

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9295185 [details] [diff] [review]
1392929-cc-contentprefs2-1_1-25315.patch

LGTM

Comment 22

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9294732 [details] [diff] [review]
1392929-mc-contentprefs2-25315.patch

LGTM

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3c84f4b1c952
Port Bug 886907 - Remove old synchronous contentPrefService to SeaMonkey - comm part. r=frg

Comment 24

[Frank-Rainer Grahl (:frg)]

Target 2.53.15
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/06ed4241aa834c6202ce4d316bf461cf6866a768
Port Bug 886907 - Remove old synchronous contentPrefService to SeaMonkey - comm part. r=frg a=frg

https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/f005f2b38c354a851df4a13c6ebe856b1ec4cb50
Remove old synchronous contentPrefService to SeaMonkey - mozilla part. r=frg a=frg