Closed Bug 1392929 Opened 8 years ago Closed 3 years ago

Port Bug 886907 - Remove old synchronous contentPrefService to SeaMonkey

Categories

(SeaMonkey :: General, defect)

Product:
SeaMonkey
Component:
General
Version:
SeaMonkey 2.54 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.53+ fixed)

Status:
RESOLVED FIXED
Milestone:
Future
Tracking Flags:
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: domfillon, Assigned: iannbugzilla)

References

Details

(Whiteboard: SM2.53.15)

User Story

Text / Font sizing not available anymore.
Data Manager broken too.
Back/Forward buttons broken

Attachments

(3 files, 1 obsolete file)

1392929-thisisnotafix.patch
3.68 KB, patch
iannbugzilla
: review+
iannbugzilla
: approval-comm-beta+
Details | Diff | Splinter Review
1392929-mc-contentprefs2-25315.patch
9.30 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review
1392929-cc-contentprefs2-1_1-25315.patch
24.51 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 SeaMonkey/2.54a1 Lightning/5.9a1 Build ID: 20170822044702 Steps to reproduce: Testing with SeaMonkey nightly (User agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 SeaMonkey/2.54a1 Build identifier: 20170822044702) The text sizing controls are not present, not effective (Ctrl +, Ctrl -) Actual results: no possibility to increase / decrease font size in browser window. Expected results: Increase / decrease font size was still working on builds 20170813 (Win32 and Win64)
The browser menu View does not show the usual Ctrl+ / Ctrl - (increase / decrease font). Regression between 20170813 and 20170822
Some more details: - The problem is still there with add-ons disabled. - The browser menu under "View" is partially there for CTRL+ and CTRL-, but not effective, either in normal or add-ons disabled modes.
Status: UNCONFIRMED → NEW
User Story: (updated)
Ever confirmed: true
Summary: Text / Font sizing not available anymore (regression) → Port Bug 886907 [Remove old synchronous contentPrefService] to SeaMonkey
Assignee: nobody → wgianopoulos
Status: NEW → ASSIGNED
As the comment says. Just a quick hack till Bill is ready with a patch. Unbreaks the browser but zoom handling/setting will likely be not ok because the old sync apis are still used.
User Story: (updated)
Assignee: wgianopoulos → nobody
Status: ASSIGNED → NEW
Comment on attachment 8903585 [details] [diff] [review] 1392929-thisisnotafix.patch This bug breaks the browser badly. I suggest putting in the interim hacky patch till the real patch is ready. Back Forward works again with it and most fuctionality too.
Attachment #8903585 - Flags: review?(iann_bugzilla)
I second that. I am using the interim patch and the only inconvenience is the lack of automatic password provision. BTW, the ancient chrome://passwordmgr/content/passwordManager.xul is infinitely more performant than the 'data manager' provided through the menus, even when this works (which it doesn't at the moment).
David, if you compile SeaMonkey yourself also put the patch for Bug 1394101 in and Data Manager should work again for everything but content prefs.
Comment on attachment 8903585 [details] [diff] [review] 1392929-thisisnotafix.patch r=me for the sticking plaster
Attachment #8903585 - Flags: review?(iann_bugzilla) → review+
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/0ca324fbb106 Temporary Fix for contentPrefService removal. r=IanN
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
status-seamonkey2.54: --- → affected
status-seamonkey2.55: --- → affected
Resolution: FIXED → ---
Status: REOPENED → NEW
Comment on attachment 8903585 [details] [diff] [review] 1392929-thisisnotafix.patch Working to fix up 2.54 now and this would help me there too.
Attachment #8903585 - Flags: approval-comm-beta?
Comment on attachment 8903585 [details] [diff] [review] 1392929-thisisnotafix.patch a=me
Attachment #8903585 - Flags: approval-comm-beta? → approval-comm-beta+
Summary: Port Bug 886907 [Remove old synchronous contentPrefService] to SeaMonkey → Port Bug 886907 - Remove old synchronous contentPrefService to SeaMonkey

[Approval Request Comment]
Regression caused by (bug #): Bug 886907
User impact if declined: features that depend on content prefs stop working
Testing completed (on m-c, etc.): 2.53.14
Risk to taking this patch (and alternatives if risky): some
String changes made by this patch: none

Assignee: nobody → iannbugzilla
Status: NEW → ASSIGNED
Attachment #9294732 - Flags: review?(frgrahl)
Attachment #9294732 - Flags: approval-comm-release?
Attachment #9294732 - Flags: approval-comm-esr60?

[Approval Request Comment]
Regression caused by (bug #): Bug 886907
User impact if declined: things that depend on content prefs don't work
Testing completed (on m-c, etc.): 2.53.14
Risk to taking this patch (and alternatives if risky): some
String changes made by this patch: none

Makes use of the extra code from the mozilla part.

Attachment #9294734 - Flags: review?(frgrahl)
Attachment #9294734 - Flags: approval-comm-release?
Attachment #9294734 - Flags: approval-comm-esr60?

Comment on attachment 9294732 [details] [diff] [review]
1392929-mc-contentprefs2-25315.patch

Remvong a content pref in the data manager now results in:

Timestamp: 17.09.2022, 18:57:53
Error: NS_ERROR_XPC_BAD_CONVERT_JS: Could not convert JavaScript argument arg 1 [nsIContentPrefService2.hasPrefs]
Source File: chrome://communicator/content/dataman/dataman.js
Line: 1918

Timestamp: 17.09.2022, 18:57:53
Error: [Exception... "Could not convert JavaScript argument arg 1 [nsIContentPrefService2.hasPrefs]" nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)" location: "JS frame :: chrome://communicator/content/dataman/dataman.js :: prefs_reactToChange :: line 1918" data: no]

Try to fix or back out first?

Attachment #9294732 - Flags: review?(frgrahl)
Attachment #9294732 - Flags: review-
Attachment #9294732 - Flags: approval-comm-release?
Attachment #9294732 - Flags: approval-comm-esr60?

Comment on attachment 9294734 [details] [diff] [review]
1392929-cc-contentprefs2-2515.patch

Services.contentPrefs2.hasPrefs(null, domain != "*" ? domain : null, {

Arguments are reversed so an easy fixer.

Next one:
Timestamp: 17.09.2022, 19:44:01
Error: TypeError: Services.contentPrefs is undefined
Source File: chrome://communicator/content/pref/pref-content.js
Line: 42

Patch with issues fixed.

Attachment #9294734 - Attachment is obsolete: true
Attachment #9294734 - Flags: review?(frgrahl)
Attachment #9294734 - Flags: approval-comm-release?
Attachment #9294734 - Flags: approval-comm-esr60?
Attachment #9295185 - Flags: review?(frgrahl)
Attachment #9295185 - Flags: approval-comm-release?
Attachment #9295185 - Flags: approval-comm-esr60?

Comment on attachment 9294732 [details] [diff] [review]
1392929-mc-contentprefs2-25315.patch

Issues fixed in cc patch

Attachment #9294732 - Flags: review?(frgrahl)
Attachment #9294732 - Flags: review-
Attachment #9294732 - Flags: approval-comm-release?
Attachment #9294732 - Flags: approval-comm-esr60?

Comment on attachment 9295185 [details] [diff] [review]
1392929-cc-contentprefs2-1_1-25315.patch

LGTM

Attachment #9295185 - Flags: review?(frgrahl)
Attachment #9295185 - Flags: review+
Attachment #9295185 - Flags: approval-comm-release?
Attachment #9295185 - Flags: approval-comm-release+
Attachment #9295185 - Flags: approval-comm-esr60?
Attachment #9295185 - Flags: approval-comm-esr60+

Comment on attachment 9294732 [details] [diff] [review]
1392929-mc-contentprefs2-25315.patch

LGTM

Attachment #9294732 - Flags: review?(frgrahl)
Attachment #9294732 - Flags: review+
Attachment #9294732 - Flags: approval-comm-release?
Attachment #9294732 - Flags: approval-comm-release+
Attachment #9294732 - Flags: approval-comm-esr60?
Attachment #9294732 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/3c84f4b1c952
Port Bug 886907 - Remove old synchronous contentPrefService to SeaMonkey - comm part. r=frg

Status: ASSIGNED → RESOLVED
Closed: 8 years ago → 3 years ago
Resolution: --- → FIXED

Target 2.53.15
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/06ed4241aa834c6202ce4d316bf461cf6866a768
Port Bug 886907 - Remove old synchronous contentPrefService to SeaMonkey - comm part. r=frg a=frg

https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/f005f2b38c354a851df4a13c6ebe856b1ec4cb50
Remove old synchronous contentPrefService to SeaMonkey - mozilla part. r=frg a=frg

status-seamonkey2.53: --- → fixed
status-seamonkey2.54: affected → ---
status-seamonkey2.55: affected → ---
tracking-seamonkey2.53: --- → +
Whiteboard: SM2.53.15
Target Milestone: --- → Future
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: