1392976 - Do not assert IsOnMessageLoopThread() in ChromiumCDMChild::GetCurrentWallTime()

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect, P1)

Description

[James Cheng[:JamesCheng]]

I think it's thread safe to call the time function.

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1392976 - Do not assert IsOnMessageLoopThread() in ChromiumCDMChild::GetCurrentWallTime().

Review commit: https://reviewboard.mozilla.org/r/171562/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171562/

Comment 2

[James Cheng[:JamesCheng]]

Comment on attachment 8900175 [details]
Bug 1392976 - Do not assert IsOnMessageLoopThread() in ChromiumCDMChild::GetCurrentWallTime().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/171562/diff/1-2/

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8900175 [details]
Bug 1392976 - Do not assert IsOnMessageLoopThread() in ChromiumCDMChild::GetCurrentWallTime().

https://reviewboard.mozilla.org/r/171562/#review176726

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0439eecf0b50
Do not assert IsOnMessageLoopThread() in ChromiumCDMChild::GetCurrentWallTime(). r=cpearce

Comment 5

[James Cheng[:JamesCheng]]

Comment on attachment 8900175 [details]
Bug 1392976 - Do not assert IsOnMessageLoopThread() in ChromiumCDMChild::GetCurrentWallTime().

Approval Request Comment
[Feature/Bug causing the regression]:NO
[User impact if declined]: user could not play DRM content. When we update new CDM.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]:
Please follow this order for uplifting
1. Bug 1390453
2. Bug 1390739
3. Bug 1390725
4. Bug 1392175 
5. This bug
[Is the change risky?]:No
[Why is the change risky/not risky?]:The change did not effect on the current CDM.  
[String changes made/needed]: No

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0439eecf0b50

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8900175 [details]
Bug 1392976 - Do not assert IsOnMessageLoopThread() in ChromiumCDMChild::GetCurrentWallTime().

5th patch (to uplift in order) for CDM update on beta.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c142cf8ec91d

Comment 9

[Andrei Vaida [:avaida]]

(In reply to James Cheng[:JamesCheng] from comment #5)
> [Is this code covered by automated tests?]: No
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: No

Setting qe-verify- based on James's assessment on manual testing needs.