1393225 - Losslessly compress photon PNG assets

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We added a lot of new assets for photon and we have not optimized them yet. Most of these assets can be reduced by 40%+ in size.

See bug 1150974 for precedent. fwiw, in the past, I've used ImageOptim on macOS and something else on linux.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

See bug 1150973 for doing this automatically in the future.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Bug 1393225: Losslessly compress png assets in photon/ dir.

I used ImageOptim and drag-and-dropped all drawable* folders.

According to ImageOptim: "Saved 139 KB out of 303 KB. 45.4% per file on average
(up to 68.3%)."

Review commit: https://reviewboard.mozilla.org/r/171840/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171840/

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Nevin: FYI that this is something we should try to do regularly, to keep the APK size down.

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8900471 [details]
Bug 1393225: Losslessly compress png assets in photon/ dir.

https://reviewboard.mozilla.org/r/171840/#review177388

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e3cd339e05d
Losslessly compress png assets in photon/ dir. r=nechen

Comment 6

[Nick Alexander :nalexander [he/him]]

(In reply to Michael Comella (:mcomella) from comment #3)
> Nevin: FYI that this is something we should try to do regularly, to keep the
> APK size down.

I think it's a built-in step in the Android Gradle plugin, but that doesn't mean we should ignore the resource costs.  Thanks for thinking of this, Mike!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7e3cd339e05d