1150974 - Losslessly compress all png assets

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I filed bug 1150973 to do this automatically from now on, but here's for a one-off push.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: bz://1150974/mcomella

/r/6611 - Bug 1150974 - Run `trimage` on all png assets in mobile/. r=rnewman

Pull down this commit:

hg pull -r a9472dff13aeac08a792bac4e69f8e191b09bae4 https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Reviewboard seems to have eaten my extended commit message so if it makes it easier, here's the command I ran in zsh:

  for i in `find mobile -name "*.png" | sed "s/\(.*\)\/.*\.png/\1/" | sort | uniq`; do trimage -d ${i}; done

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8588069 [details]
MozReview Request: bz://1150974/mcomella

Assuming that they're not lying when they say 'lossless':

* Visually verify a build. Make sure that this doesn't do something bad like shifting color spaces or palettes.

* Verify that it doesn't make a change if the resulting images are larger than the input (which can happen!).

rs=me!

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Richard Newman [:rnewman] from comment #3)
> * Visually verify a build. Make sure that this doesn't do something bad like
> shifting color spaces or palettes.

I haven't seen any issues with this in my local build, nor in the past (and neither has Anthony! :). 

> * Verify that it doesn't make a change if the resulting images are larger
> than the input (which can happen!).

Without taking the time to write a script or digging into the source, I'm not quite sure how to verify that none of the images grow in size. I listed the files before and after the patch with their file sizes and of the tens or so that I looked at, the size was reduced. I verified the final APK has dropped in size and I've previously noticed that re-running the program on the same image will cause no differences under `hg diff`.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/8af5effde9d5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8af5effde9d5

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1150974 - Run `trimage` on all png assets in mobile/. r=rnewman