1393313 - Favicons in Bookmarks menu flicker rapidly; menu lags a lot

Status: NEW

(Core :: Graphics, defect, P2)

Description

[Jonathan Chan [:jyc]]

The favicons in the bookmarks menu flicker very rapidly on macOS while the menu lags a ton. This makes the bookmarks menu pretty unpleasant to use.

Bug 1374800 is potentially related, but I'm not running the Activity Stream Test Pilot.

This only seems to happen sometimes, but when it does, it doesn't go away until I exit the menu. I'm still trying to figure out how to trigger it again so I can take a video.

Comment 1

[Jonathan Chan [:jyc]]

Attachment: flickering-bookmarks-menu.mp4

Was able to reproduce while watching a YouTube video. This seems to reliably reproduce the issue for me.

Comment 2

[Marco Bonardo [:mak]]

This is not Bug 1374800, there the icon would disappear and reappear, while here it seems to change gamma or something similar.
From the video it looks more like a graphics issue.
I assume you have all the system updates installed?

For now I'm moving to graphics, maybe there someone has an idea of what could be done to investigate it. Unfortunately this could be a problem at various levels (graphics, layout, platform widgets) and thus it may not be trivial to figure out the cause.

Comment 3

[Jonathan Chan [:jyc]]

Hi! Yep, all the system updates are installed. FWIW I haven't run into this problem on Linux.

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

We could really use a regression range to get this moving.  Mozregression tool is great.

Comment 6

[Jet Villegas (inactive)]

The favicons in the history menu don't flicker, just the bookmarks menu.

Comment 7

[Jet Villegas (inactive)]

And with bug 1401238 fixed, I don't see this happening anymore. It seems the Pocket bookmark item was causing the flicker for me. If other add-ons can add menu items that cause us to flicker, that still needs to be fixed.

Comment 8

[Cristina Badescu [:cbadescu], Experiments QA]

Attachment: Recording #7.mp4

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:58.0) Gecko/20100101 Firefox/58.0; Version: 58.0a1
Build ID: 20170925100307

Hello,

I tested this issue using latest Nightly build 58.0a1 and I managed to partially reproduce it:

Preconditions:
- Have a large amount of items bookmarked, for e.g. 15-20 websites.

Steps to reproduce:

1. Have a YouTube page opened while playing a video.
2. Add to "Bookmarks" a new page.
3. Come back on the YouTube Page and click on "Bookmarks" from the browser toolbar.
4. Observe the behavior.

Actual results:
- The website icons are flickering for a few seconds.

Notes:
- This issue reproduces only after adding a new page to the present "Bookmarks" list.
- Attached a screen recording of the issue.

Jonathan, is this issue still reproducible at your end using latest Nightly build?
Jet, is there any change that bug 1401238 didn't fix this? I have tried to perform a regression but the described bevaior is still reproducing on the Nightly build from 2017-02-10.

Comment 9

[Milan Sreckovic [:milan] (needinfo for best results)]

Wonder if it's related to bug 1404422.

Comment 10

[Jonathan Chan [:jyc]]

Hi Cristina,

Sorry for the very delayed reply. I haven't been able to reproduce this using the latest Nightly build. Unfortunately I am still swamped and do not have the time to use mozregression right now. I will try to do one soon, though, if I run into the bug again. Very sorry.

Comment 11

[Jet Villegas (inactive)]

(In reply to Cristina Badescu from comment #8)
> Jet, is there any change that bug 1401238 didn't fix this?

I can reproduce this issue with the steps described in comment 8. However, it's not nearly as severe as when we had the Pocket bookmarks before bug 1401238 was fixed.