1393834 - Remove the extensions.legacy.exceptions pref

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, enhancement, P5)

Description

[Andy McKay]

This was added so that some add-ons wouldn't show "legacy" on about:addons. With the resigning of everything to external add-ons and the switch to Firefox 57 and legacy add-on only we should be able to remove this.

Comment 1

[Andrew Swan [:aswan]]

As of 57, that pref only applies to the UI when "extensions.legacy.enabled" has been flipped to true (in a build that honors it).
In that case, the exceptions pref is used for a bunch of test pilot addons and the default theme.  Test pilot should be okay now but there's still the default theme.  We could:
- replace the pref with a hard-coded exception for the default theme
- remove the pref and let the UI show a bogus "LEGACY" badge next to the default them
- remove LEGACY badges altogether
- do nothing for now

I vote for the last option

Comment 2

[Andy McKay]

Ah good to know the first part. I agree with your vote. So let's leave this in the "stuff to clean out later on" bucket.

Comment 3

[Kris Maglione [:kmag]]

Note that this also lets us remove the browser_legacy.js and browser_legacy_pre57.js tests, and their associated resources.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Everything except the pref itself was removed in bug 1563062

Comment 5

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1393834 remove legacy.exceptions pref, code using it was removed

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdeec504ed04
remove legacy.exceptions pref, code using it was removed r=rpl

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/fdeec504ed04

Comment 8

[Miruna Curtean]

The preference has been removed from FF Nightly 73.0a1 (20191213094653). However, it is still listed with a false value on the same build ID on Ubuntu 18.04 LTS and on macOS Catalina 10.15 on FF 73.0a1 Buiild ID:20191212095326.

Comment 9

[Shane Caraveo (:mixedpuppy)]

I'm not seeing that on osx 10.14 and I see no source that has this pref name in m-c. Where do you see this value?

Comment 10

[Miruna Curtean]

I was looking in about:config for the preference.
Rechecked on Ubuntu 18.04.3 LTS and macOS 10.15 Catalina.
On the latest Firefox version 73.0a1 and build (20191215214948) the extensions.legacy.exceptions is not listed so I marking this as verified fixed.