1394094 - Collapsed JSON properties break URLs (application/json view)

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, defect, P3)

Description

[Geoffrey De Belie (Smile4ever)]

Attachment: JSON data

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170821100350

Steps to reproduce:

I opened nl.json in Firefox. When the URL properties are collapsed, those URLs no longer work.

Steps to reproduce
* collapse the XmlViewUrl property, 
* Instead of http://mycroftproject.com/installos.php/57541/bbcradio.xml I get http://mycroftproject.xn--co-hg4n.php/57541/bbcradio.xml which clearly doesn't work.

Sample data in attachment.

Comment 1

[Tooru Fujisawa [:arai]]

it's from bug 1386525 (not a regression, but just a new feature), and the actual change seems to be the following one:
  https://github.com/devtools-html/devtools-core/commit/e76954d19d0942a1d6038e42366852970d0cbbac

https://github.com/devtools-html/devtools-core/blob/adb20d44c133a9751cd3ed0528a0ced3d39ec743/packages/devtools-reps/src/reps/string.js#L81-L88

there I think `token` can be collapsed string and in that case we should use the original string, or avoid linkification?

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

I can confirm the bug, and I opened an issue in the Github repository to fix it : https://github.com/devtools-html/devtools-core/issues/616

Comment 4

[Oriol Brufau [:Oriol]]

Fixed in bug 1419479 and added test in bug 1426094.