Closed Bug 1394137 Opened 4 years ago Closed 4 years ago
Stop changing the Go button's color on hover
59 bytes, text/x-review-board-request
The Go button on the awesomebar, updated in Bug 1391395, has a green hover color using the default theme. Per the Photon color guidelines, accents color for highlighting buttons should be from the blue palette. Thanks!  http://design.firefox.com/photon/visual/color.html
Stephen, should we change this color?
There is no special state we need to convey for this. We should just use the same hover / active attribute as the rest of the icons in that area — Grey. Green was a hold over from the Blue / Red / Green when it was the Reload / Stop / Go button.
So we just need to remove this rule: http://searchfox.org/mozilla-central/rev/4d8e389498a08668cce9ebf6232cc96be178c3e4/browser/themes/shared/urlbar-searchbar.inc.css#186-191
Hi, can i work on this bug?
(In reply to akriti verma from comment #4) > Hi, can i work on this bug? Sure. Do you have the source code and have you built Firefox yet?
Comment on attachment 8905570 [details] Bug 1394137 - Stop changing the Go button's color on hover https://reviewboard.mozilla.org/r/177376/#review182370 Looks good. Thanks!
Attachment #8905570 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/26d748e59642 Stop changing the Go button's color on hover r=dao
You need to log in before you can comment on or make changes to this bug.