Closed Bug 1397755 Opened 7 years ago Closed 4 years ago

Increase margin of tab list menu when triggered by touch

Categories

(Firefox :: Tabbed Browser, enhancement, P3)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 77
Tracking Status
firefox57 --- wontfix
firefox77 --- verified

People

(Reporter: past, Assigned: mstriemer)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(1 file)

The tab list menu that opens from the down arrow in the tab bar, next to the new tab button, doesn't use bigger margins like the rest of the photon menus when triggered by a touch event. For consistency with the rest of the menus it should be updated as well.
Whiteboard: [photon-visual][triage]
Blocks: photon-touch
Flags: qe-verify+
Priority: -- → P4
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
QA Contact: ovidiu.boca
Priority: P4 → P3
Blocks: fx-touch
No longer blocks: photon-touch

Oops I think I just filed a duplicate of this here https://bugzilla.mozilla.org/show_bug.cgi?id=1628171
Is there a good reason why this one hasn't been fixed? I can't imagine this one being tricky to fix

Blocks: tab-manager
See Also: → 1371219, 1364896

Manually adding touchmode=true to the all tabs panel displays the panel as touch friendly:
https://searchfox.org/mozilla-central/rev/9120151ddb35f2d4c37bfe613a54a4f10a9a3dc5/browser/themes/windows/browser.css#816

I guess this:
https://searchfox.org/mozilla-central/rev/9120151ddb35f2d4c37bfe613a54a4f10a9a3dc5/browser/base/content/browser.js#8495-8502
should be fired for customizationui-widget-panel to fix this issue.

Assignee: nobody → mstriemer
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/910beb76331c
Use touch density for all tabs list with touch r=dao
Component: Theme → Tabbed Browser
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77

Tested on a touch screen laptop and it works great.
Thanks, mstriemer!

Status: RESOLVED → VERIFIED

Thank you for fixing this! Can you also fix this one with Quantumbar since it's pretty much the same thing? https://bugzilla.mozilla.org/show_bug.cgi?id=1629117

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: