1398481 - WebExtensions - Embedded add-on options page does not zoom when Add-ons Manager (about:addons) page is zoomed

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P5)

Description

[dw-dev]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170809080026

Steps to reproduce:

In Firefox 56 or Firefox 57:

1. Select Tools > Add-ons.
2. Select Extensions tab.
3. Click Options button of any WebExtensions add-on (e.g. Print Edit WE)
4. Increase the zoom level to 200%.



Actual results:

The options dialog (embedded options page) for Print Edit WE does not increase in size (is not zoomed).


Expected results:

The options dialog (embedded options page) for Print Edit WE should increase in size (should be zoomed).

Comment 1

[Marcy Sutton]

It's unfortunate that this was marked as "wontfix". Even though the issue is specifically about extension options, not fixing zoom issues means that users with low vision may have a difficult time using Firefox.

Comment 2

[Andrew Swan [:aswan]]

(In reply to Marcy Sutton from comment #1)
> It's unfortunate that this was marked as "wontfix".

It was marked as wontfix for Firefox 57 which shipped more than a year ago.  The bug is still open, albeit not a high priority.

Comment 7

[Mark Striemer [:mstriemer]]

Emilio, do you know how we might get the extension's browser here to zoom with the page zoom? This bug has a couple other attached to it and I'm somewhat curious if zooming the extension's browser would help fix them

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Can you elaborate what you mean? The extension browser seems zoomed in / out. I was using the tree style tabs option page for reference, and text becomes larger / smaller as I zoom in and out.

Comment 9

[Michael C. Irvin]

Attachment: 100%.jpg

100% scaling for TST from about:addons.

Comment 10

[Michael C. Irvin]

Attachment: 200%.jpg

200% scaling for TST from about:addons.

Comment 11

[Michael C. Irvin]

Emilio, I think these screenshots show the situation. You can see parts of the screen are being scaled properly, but others are not. If you click on the "Open this options page in more wide space", that page properly responds to scaling. (Ex: moz-extension://6939839e-4af5-451a-a51f-c1c4fdc46bc4/options/options.html#!)

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Attachment: Emilio's nightly with 200% zoom

Huh, odd. I do see those contents scaled here... Are you on nightly as well?

Comment 13

[Michael C. Irvin]

No, sorry ... I am on FF83.

Comment 14

[Emilio Cobos Álvarez (:emilio)]

It'd be good to check if this is fixed on Nightly for you too or if this is somehow OS-specific or something. If you could try a build from https://nightly.mozilla.org it'd be great, but no worries if not, I can check on a Windows machine next week.

Comment 15

[Mark Striemer [:mstriemer]]

Attachment: addon-options-zoom.mov.gif

Here's an example zooming from macOS nightly. The page is zooming but the content provided by the extension here doesn't grow. The text inputs are the same size at all zoom levels.

Comment 16

[Michael C. Irvin]

Attachment: 400% - Nightly (FF85) - Windows.jpg

I fired up Windows Sandbox, installed Nightly (85.0a1 (2020-12-12) (64-bit)), installed TST ... still not working.

Comment 17

[Mark Striemer [:mstriemer]]

Emilio, looks like Michael and I aren't seeing the zoomed content within the Preferences/Options tab here. It looks like in your screenshot it isn't zoomed as well, the text in the extension provided content in the Preferences tab appears to be its regular size.

Any idea how we might go about fixing this?

Comment 18

[Emilio Cobos Álvarez (:emilio)]

So the text in my page is definitely zoomed, but I think I figured out why. I was zooming with Ctrl+Mousewheel when pointing to the settings page.

D'oh. I can repro the issue when zooming with Ctrl+/Ctrl-.

Comment 19

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1398481 - Propagate zooms to add-on options browser. r=mstriemer

Full zoom causes the window to resize, so we use this to detect the
change. We could probably listen to the FullZoomChanged event on
embedder browser or something, but that seemed a bit more complicated.

Comment 20

[Emilio Cobos Álvarez (:emilio)]

Something like that?

Comment 21

[Emilio Cobos Álvarez (:emilio)]

Actually to handle text zoom we need to do the hard thing, so did that.

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71e96c86c84c
Propagate zooms to add-on options browser. r=mstriemer

Comment 23

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/71e96c86c84c