1399075 - Colon sign is displayed in "about:preferences#general" page in "Color" sub-dialog

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Hani Yacoub, Desktop QA]

Attachment: colon sign.png

[Affected versions]: 
Nightly 57.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.

[Steps to reproduce]:
1. Open firefox.
2. Go to "about:preferences#general".
3. Click on "Color" button.

[Expected result]:
All colon signs on sub-dialogs should be removed.

[Actual result]:
Colon sign is displayed in "about:preferences#general" page in "Color" sub-dialog

[Note]:
There is another colon sign displayed in an "Connection Setting" sub-dialog under Network Proxy section.

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1399075 - Remove colon sign in Preferences's Color sub-dialog

Review commit: https://reviewboard.mozilla.org/r/179078/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/179078/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8907392 [details]
Bug 1399075 - Remove colon sign in Preferences's Color sub-dialog

https://reviewboard.mozilla.org/r/179078/#review184514

Thanks for the patch! This looks fine.

Note that in comment 0, Hani says:

"There is another colon sign displayed in an "Connection Setting" sub-dialog under Network Proxy section". Do we want to do that in a follow-up bug?

Comment 3

[Ricky Chien [:rickychien] (inactive)]

After scanning http://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/preferences/ folder, I still see a few colon signs haven't been removed. I'll file a follow up bug for that.

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8907392 [details]
Bug 1399075 - Remove colon sign in Preferences's Color sub-dialog

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/179078/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ca5a17fbf90
Remove colon sign in Preferences's Color sub-dialog r=mconley

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Follow up bug filed in bug 1399699.

(In reply to Hani Yacoub from comment #0)
> [Note]:
> There is another colon sign displayed in an "Connection Setting" sub-dialog
> under Network Proxy section.

Hani, I can't find any redundant colon sign in "Connection Setting" sub-dialog. Can you verify that again? Perhaps you can add your new findings in bug 1399699.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7ca5a17fbf90

Comment 8

[Hani Yacoub, Desktop QA]

I can't see it either now. And I'm sure I wasn't referring to the colon sign after example.
I guess I can verify it when the fix will be landed.
Thanks.

Comment 9

[Hani Yacoub, Desktop QA]

Build ID: 20170914100122
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.