1400087 - Autophone - Talos broken on 57+ due to disabling of legacy extensions

Status: VERIFIED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

+++ This bug was initially created as a clone of Bug #1399687 +++

Autophone Talos began perma failing after Bug 1391401 - Limit add-ons loaded into Firefox for Android landed:

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=337bae3d28e485077d8518331171eec33de84b5f&filter-searchStr=autophone&filter-tier=1&filter-tier=2&filter-tier=3

I changed the extensions.legacy.enabled to True in bug 1399687 but apparently that doesn't work with beta now that 57 has uplifted. So Autophone is unable to run Talos on beta or release now.

Comment 1

[Andrew Swan [:aswan]]

Hi, sorry I missed this when landing bug 1391401.  I'm not sure exactly what Autophone is but here's some background:
extensions.legacy.enabled will only work in release and beta if Cu.isInAutomation is true, and that in turn is true if the preference security.turn_off_all_security_so_that_viruses_can_take_over_this_computer (yes that is the actual name) is set to true and the environment variable MOZ_DISABLE_NONLOCAL_CONNECTIONS is set.  That is all the case for Talos on desktop (see bug 1361002, it didn't occur to me that Android probably uses a different harness for launching Talos tests.

Comment 2

[Bob Clary [:bc] (inactive)]

Thanks! That's an easy fix. We already disable non local connections and I can easily add the pref.

Comment 3

[Bob Clary [:bc] (inactive)]

Attachment: bug-1400087-v1.patch

Comment 4

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/bed5129c6f1b301821860c2044c4b14e742fe036
shutting down to deploy now.

Thanks everyone! This was much less painful than I imagined it would be.

Comment 5

[Intermittent Failures Robot]

4 failures in 1032 pushes (0.004 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-beta: 4

Platform breakdown:
* android-6-0-armv8-api16: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1400087&startday=2017-09-11&endday=2017-09-17&tree=all