Closed Bug 1400087 Opened 3 years ago Closed 3 years ago

Autophone - Talos broken on 57+ due to disabling of legacy extensions

Categories

(Testing :: Autophone, defect)

defect
Not set

Tracking

(firefox57 verified)

VERIFIED FIXED
Tracking Status
firefox57 --- verified

People

(Reporter: bc, Assigned: bc)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1399687 +++

Autophone Talos began perma failing after Bug 1391401 - Limit add-ons loaded into Firefox for Android landed:

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=337bae3d28e485077d8518331171eec33de84b5f&filter-searchStr=autophone&filter-tier=1&filter-tier=2&filter-tier=3

I changed the extensions.legacy.enabled to True in bug 1399687 but apparently that doesn't work with beta now that 57 has uplifted. So Autophone is unable to run Talos on beta or release now.
Flags: needinfo?(jmaher)
Flags: needinfo?(aswan)
Hi, sorry I missed this when landing bug 1391401.  I'm not sure exactly what Autophone is but here's some background:
extensions.legacy.enabled will only work in release and beta if Cu.isInAutomation is true, and that in turn is true if the preference security.turn_off_all_security_so_that_viruses_can_take_over_this_computer (yes that is the actual name) is set to true and the environment variable MOZ_DISABLE_NONLOCAL_CONNECTIONS is set.  That is all the case for Talos on desktop (see bug 1361002, it didn't occur to me that Android probably uses a different harness for launching Talos tests.
Flags: needinfo?(aswan)
Thanks! That's an easy fix. We already disable non local connections and I can easily add the pref.
Assignee: nobody → bob
Status: NEW → ASSIGNED
Flags: needinfo?(jmaher)
Attachment #8908630 - Flags: review?(jmaher)
Attachment #8908630 - Flags: review?(jmaher) → review+
https://github.com/mozilla/autophone/commit/bed5129c6f1b301821860c2044c4b14e742fe036
shutting down to deploy now.

Thanks everyone! This was much less painful than I imagined it would be.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.