1400668 - Process key handle exclusion list when registering a token

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect, P2)

Description

[Tim Taubert [:ttaubert] (inactive)]

It's all there, we just need to forward the exclusion list and make the proper queries in the Rust lib.

Comment 1

[Phabricator Automation]

Comment on attachment 8909105 [details]
Bug 1400668 - Process key handle exclusion list when registering a token r=jcj

J.C. Jones [:jcj] has approved the revision.

https://phabricator.services.mozilla.com/D64#1410

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e907fa0c6d37
Process key handle exclusion list when registering a token r=jcj

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4294dd8b8c9
Fix Android builds on a CLOSED TREE by adding the key_handles arg to the stub PlatformManager r=bustage

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e907fa0c6d37
https://hg.mozilla.org/mozilla-central/rev/e4294dd8b8c9

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8909105 [details]
Bug 1400668 - Process key handle exclusion list when registering a token r=jcj

Approval Request Comment
[Feature/Bug causing the regression]: No regression, missing feature.
[User impact if declined]: Might break testing the U2F/WebAuthn API.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Manually, yes.
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: Not risky.
[Why is the change risky/not risky?]: U2F/WebAuthn are not enabled by default.
[String changes made/needed]: None.

This is not critical but it would be nice to have if folks are going to test U2F/WebAuthn in Firefox 57. It's disabled by default but can be enabled via a pref. Low risk because it only touches dom/webauthn.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8909105 [details]
Bug 1400668 - Process key handle exclusion list when registering a token r=jcj

Happy to help if this remains disabled in 57. 
Should be in 57b3

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/aa837b37b60c