1401297 - [10.13] Native titlebars are visible when exiting native fullscreen

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[Stephen A Pohl [:spohl] (OOO until 2/27)]

Split out from bug 1400057.

STR:
1. Click the green fullscreen button in the top left corner of the browser window.
2. Move the mouse towards the top of the screen to reveal the native titlebar.
3. Click on the green button again to exit native fullscreen mode.

Expected:
Titlebar and tabs displays as expected.

Actual:
Native titlebar appears on top of tabs.

Comment 1

[Stephen A Pohl [:spohl] (OOO until 2/27)]

Attachment: Patch

Carrying over patch and r+ from attachment 8909811 [details] [diff] [review] in bug 1400057.

Comment 2

[Stephen A Pohl [:spohl] (OOO until 2/27)]

(In reply to Stephen A Pohl [:spohl] from comment #1)
> Created attachment 8909926 [details] [diff] [review]
> Patch
> 
> Carrying over patch and r+ from attachment 8909811 [details] [diff] [review]
> in bug 1400057.

This should have read attachment 8909843 [details] [diff] [review].

Comment 3

[Stephen A Pohl [:spohl] (OOO until 2/27)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f53d94fca971e3a6f6e742793dabbef8eb96f5de
Bug 1401297: Hide native titlebars on macOS 10.13 when exiting native fullscreen. r=mstange

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f53d94fca971

Comment 5

[Stephen A Pohl [:spohl] (OOO until 2/27)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/938750d859b85600b84013bd6dea63db1c32d135
Bug 1401297: Followup to fix the selector checks in changeset f53d94fca971. r=mstange

Comment 6

[Stephen A Pohl [:spohl] (OOO until 2/27)]

Attachment: Followup

The patch had a copy/paste error in the selector checks, which is fixed in this followup. Carrying over r+ since this was what was reviewed (indirectly, via bug 1398582 comment 30) and should have landed in the first place.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/938750d859b8