1401793 - XML pretty print viewer is too easily disabled by extensions

Status: REOPENED

(Core :: XML, defect, P5)

Description

[Mike Kaply [:mkaply]]

If you have this extension installed:

https://addons.mozilla.org/en-US/firefox/addon/check-this-by-metacert/?src=userprofile

When you navigate to an XML file, it comes up blank instead of displaying the XML tree view. For instance:

https://aus5.mozilla.org/update/6/Firefox/54.0.1/20170628075643/WINNT_x86-msvc-x64/en-US/release/Windows_NT%2010.0.0.0%20(x64)(noBug1296630v1)(nowebsense)/SSE3/default/default/update.xml

I don't see any obvious errors on the console.

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

The developer has been contacted via AMO.

Comment 4

[Kestrel]

This bug and its duplicates have bounced between different components from XML to WebExtensions to Tech Evangelism but I think it is very much an XML issue. Extension content scripts are injected into XML pages by design and ideally extension authors would be more mindful of that but a lot of them will fail to test there so ultimately it falls back on the XML pretty printer to be more robust.

Chrome's XML pretty printer is harder to disable than Firefox's, for example changing the style of elements via class attribute does not disable it while Firefox does.

A similar story can be seen in Bug 1404933 Comment #0:
> This bug[1] affects the Vimium-ff[2] extension, since we have to inject HTML
> into the active document to show our UI. Note that this works as expected in
> Chrome.

Improving the compatibility of pretty print would go a long way to avoiding most issues with extensions. 

Also interesting to note that Firefox's Inspector only shows the root element while Chrome shows the full pretty print HTML source.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

May I know why this is dup'd to bug 1437956? We simply change the technology to put the pretty print DOM; we will still opt out of it when DOM changes.

Comment 9

[Masatoshi Kimura [:emk]]

Reopening because this bug is not fixed yet and :kmag didn't respond.

Comment 10

[Maciej Jaros]

I think this is fixed with bug 1605657. Or at least it is fixed for LastPass. FF 74.0b4 works fine with LastPass enabled.

Example URL that didn't work in 73 and works in 74:
http://data.bn.org.pl/oai/bibs?verb=ListIdentifiers&metadataPrefix=marc21&from=2019-11-01T00:00:00Z&until=2019-12-10T00:00:00Z

Comment 11

[Mike Kaply [:mkaply]]

I just tried with the latest nightly and this bug can still be recreated. Install the above extension and navigate to the XML and it is blank.