1403490 - enable mochitest-gpu tests on taskcluster windows 10

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: General, task)

Description

[Rob Thijssen [:grenade (EET/UTC+0300)]]

suite mochitest-gpu succeeds for taskcluster windows 10 builds, it would be good to have the windows 10 gpu tests that succeed running regularly.

Comment 1

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Attachment: Bug 1403490 - enable mochitest-gpu on tc win 10;

Review commit: https://reviewboard.mozilla.org/r/183970/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183970/

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8912640 [details]
Bug 1403490 - enable mochitest-gpu on tc win 10;

https://reviewboard.mozilla.org/r/183970/#review189164

excellent

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8737573b0e0
enable mochitest-gpu on tc win 10; r=jmaher

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e8737573b0e0

Comment 5

[Phil Ringnalda (:philor)]

And backed out in https://hg.mozilla.org/mozilla-central/rev/e1f660fc493bc4bf2f91b6df94bc98e8e3840c42 because according to https://public-artifacts.taskcluster.net/RNMMR272QPWy3xRj2KUG4Q/0/public/logs/live_backing.log you have to do something about a supersederUrl.

Comment 6

[Rob Thijssen [:grenade (EET/UTC+0300)]]

hey Dustin, do you know what the supersederUrl is and what i could or should do differently in this commit? just looking for pointers or a shrug as i haven't a clue about the exception thrown.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Looks like this is coming from coscaling:
https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/transforms/task.py#833-835

Just speculating.... Maybe that is not a coscaled task?

Comment 8

[Rob Thijssen [:grenade (EET/UTC+0300)]]

pmoore: asking because i've seen your comments about windows test coalescing, do you have any idea what this supersederUrl exception is about? it seems odd that the attribute is set in the build_docker_worker_payload function since i don't understand why that should run for generic-worker payloads...

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8912640 [details]
Bug 1403490 - enable mochitest-gpu on tc win 10;

https://reviewboard.mozilla.org/r/183970/#review189722

Comment 10

[Dustin J. Mitchell [:dustin] (he/him)]

I'm guessing this workerType doesn't have a new enough version of generic-worker.  It was only implemented in generic-worker a month or two ago.

Comment 11

[Pete Moore [:pmoore][:pete]]

(In reply to Dustin J. Mitchell [:dustin] from comment #10)
> I'm guessing this workerType doesn't have a new enough version of
> generic-worker.  It was only implemented in generic-worker a month or two
> ago.

That's correct. Sorry about that!

To roll this out you'll need to do one of the following:

1) Upgrade gecko-t-win10-64-gpu to generic-worker 10.2.2 or higher (ideally 10.2.3)
  OR
2) Add "gecko-t-win10-64-gpu" to this list https://hg.mozilla.org/mozilla-central/file/76a26ef7c493/taskcluster/taskgraph/transforms/coalesce.py#l34
  OR
3) Depend on bug 1399401 (i.e. wait for it to land first)

It looks like gecko-t-win10-64-gpu is currently running generic-worker 8.3.0.

Comment 12

[Pete Moore [:pmoore][:pete]]

Option 2 is no doubt the simplest...

Comment 13

[Pete Moore [:pmoore][:pete]]

Attachment: bug1403490_gecko_disable-superseding_v1.patch

Comment 14

[Rob Thijssen [:grenade (EET/UTC+0300)]]

please land both patches either together or first land the one from pmoore, followed by mine.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea65750e9e40
disable superseding for worker type gecko-t-win10-64-gpu,r=grenade
https://hg.mozilla.org/integration/mozilla-inbound/rev/82f07257d932
enable mochitest-gpu on tc win 10; r=jmaher

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ea65750e9e40
https://hg.mozilla.org/mozilla-central/rev/82f07257d932