1403853 - Hide the menu button separator in popup windows

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P1)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1400232 +++

Popup windows have no other buttons besides the menu button, so the separator is pretty much useless.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1403853 - Hide the menu button separator in popup windows.

Review commit: https://reviewboard.mozilla.org/r/184512/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184512/

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8913094 [details]
Bug 1403853 - Hide the menu button separator in popup windows.

https://reviewboard.mozilla.org/r/184512/#review189660

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2b369de68ee
Hide the menu button separator in popup windows. r=nhnt11

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d2b369de68ee

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 8913094 [details]
Bug 1403853 - Hide the menu button separator in popup windows.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1015163
[User impact if declined]: no big impact, this is just polish
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial CSS fix
[String changes made/needed]: /

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8913094 [details]
Bug 1403853 - Hide the menu button separator in popup windows.

Polish photon, taking it.
Should be in 57b5

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0460ea0333f9