Hide the menu button separator in popup windows

RESOLVED FIXED in Firefox 57

Status

()

defect
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

({polish})

Trunk
Firefox 58
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox57 fixed, firefox58 fixed)

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #1400232 +++

Popup windows have no other buttons besides the menu button, so the separator is pretty much useless.
Comment on attachment 8913094 [details]
Bug 1403853 - Hide the menu button separator in popup windows.

https://reviewboard.mozilla.org/r/184512/#review189660
Attachment #8913094 - Flags: review?(nhnt11) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d2b369de68ee
Hide the menu button separator in popup windows. r=nhnt11
https://hg.mozilla.org/mozilla-central/rev/d2b369de68ee
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Flags: qe-verify?
Flags: qe-verify? → qe-verify-
Blocks: 1404248
Comment on attachment 8913094 [details]
Bug 1403853 - Hide the menu button separator in popup windows.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1015163
[User impact if declined]: no big impact, this is just polish
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial CSS fix
[String changes made/needed]: /
Attachment #8913094 - Flags: approval-mozilla-beta?
Comment on attachment 8913094 [details]
Bug 1403853 - Hide the menu button separator in popup windows.

Polish photon, taking it.
Should be in 57b5
Attachment #8913094 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.