Update webrender to fae962bfd6e1997f4b921ee93c3c1cc5abca3256

RESOLVED FIXED in Firefox 58

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

(Blocks 2 bugs)

58 Branch
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

(Whiteboard: [wr-mvp] [gfx-noted])

Attachments

(3 attachments, 1 obsolete attachment)

+++ This bug was initially created as a clone of Bug #1412280 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh
Blocks: 1406451
Blocks: 1414157
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #5)
> Not a whole lot has landed in WR since the last update, so maybe I'll wait
> until next week to do the next update.

Fixing bug 1406451 would be a big win for our Windows testers, at least.
(In reply to Markus Stange [:mstange] from comment #6)
> Created attachment 8924823 [details] [diff] [review]
> Initialize the new field that was added in webrender commit
> 479d43ab4f245c42b33e12f9b6f050045ec84ab3.

Thanks!

(In reply to Markus Stange [:mstange] from comment #7)
> Fixing bug 1406451 would be a big win for our Windows testers, at least.

Ok, I can do the update today then.
Blocks: 1403198
Alias: wr-future-update
Assignee: nobody → bugmail
No longer blocks: 1411627
Summary: Future webrender update bug → Update webrender to fae962bfd6e1997f4b921ee93c3c1cc5abca3256
Version: unspecified → 58 Branch
Comment hidden (mozreview-request)
Status: NEW → ASSIGNED
Priority: P2 → P1
Attachment #8924823 - Attachment is obsolete: true

Comment 13

2 years ago
mozreview-review
Comment on attachment 8925015 [details]
Bug 1413178 - Initialize the new field that was added in webrender commit 479d43ab4f245c42b33e12f9b6f050045ec84ab3.

https://reviewboard.mozilla.org/r/196268/#review201434

I missed this instance, which also needs to be initialized: http://searchfox.org/mozilla-central/rev/af86a58b157fbed26b0e86fcd81f1b421e80e60a/gfx/2d/ScaledFontDWrite.cpp#317
Comment hidden (mozreview-request)
^ updated. Also added the patch that regenerates the FFI header, which I somehow lost along the way. Try push to make sure it compiles everywhere: 

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e59bbfcbb02ebefb3f33c028d3a3201430406144

Also it's probably a good idea to have cbindgen generate constructors for the structs so we're required to initialize all the things at all the call sites. This is the second time in recent memory we've had this problem where a new field is added and the compiler doesn't tell us that it might be going uninitialized.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Attachment #8925035 - Flags: review?(jmuizelaar)
Attachment #8925015 - Flags: review?(jmuizelaar) → review+
Attachment #8925014 - Flags: review?(jmuizelaar) → review+

Comment 19

2 years ago
mozreview-review
Comment on attachment 8925015 [details]
Bug 1413178 - Initialize the new field that was added in webrender commit 479d43ab4f245c42b33e12f9b6f050045ec84ab3.

https://reviewboard.mozilla.org/r/196268/#review201502

Comment 20

2 years ago
mozreview-review
Comment on attachment 8925014 [details]
Bug 1413178 - Update webrender to commit fae962bfd6e1997f4b921ee93c3c1cc5abca3256.

https://reviewboard.mozilla.org/r/196266/#review201504

Comment 22

2 years ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/000dee2bb6ba
Update webrender to commit fae962bfd6e1997f4b921ee93c3c1cc5abca3256. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/033d34b29a64
Re-generate FFI header. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/e0f98b3490f6
Initialize the new field that was added in webrender commit 479d43ab4f245c42b33e12f9b6f050045ec84ab3. r=lsalzman
You need to log in before you can comment on or make changes to this bug.