1413178 - Update webrender to fae962bfd6e1997f4b921ee93c3c1cc5abca3256

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1412280 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ c0194de78ce26106a8497484dc8d159069e3a482

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f13eb300fd675b7d56bf9417527070356066c5c
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fb5c899866ac307ebf87934f89ad630e76746a1

Green so far

Comment 2

[Kartikaya Gupta (email:[e-mail])]

WR @ 3c48c135b70bce2576db7256581878b8a75dd5e2

https://treeherder.mozilla.org/#/jobs?repo=try&revision=427ddd05db8e22dde0e9b931158d6a4531b72d04
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9ba6bd5f22fc96252e38c7a0846ace67d448fa8

Green

WR @ 82e85d7f407ff38f08fb0901724918704d6d2e4a

https://treeherder.mozilla.org/#/jobs?repo=try&revision=22199600b15aa7b83c0f993801ffe5c689c64f88
https://treeherder.mozilla.org/#/jobs?repo=try&revision=eedbecc81e6ac89b2012ba4c6b351bd03b452b8c

Green

Comment 3

[Kartikaya Gupta (email:[e-mail])]

WR @ 82e85d7f407ff38f08fb0901724918704d6d2e4a

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9beaea7e6d4c10e6db910ccb8bcdce91e8feff4
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6886fbe50005fb854ff479add2c8996f48089b04

Green

Comment 4

[Kartikaya Gupta (email:[e-mail])]

WR @ 07405419f1d18319e8865839bc268053d1c664f2

https://treeherder.mozilla.org/#/jobs?repo=try&revision=44756552fe470290b854c66573a5d7ab07b13d3e
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e9e2c4683f1e74a3f23974db14f6aaf35cbaf8d
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecb70957faa35b93481518790100b30b0a94663c
https://treeherder.mozilla.org/#/jobs?repo=try&revision=aad3e8a308f7ef0a16876d92f44cbf877cc63c84

Green

Comment 5

[Kartikaya Gupta (email:[e-mail])]

WR @ 07405419f1d18319e8865839bc268053d1c664f2, still

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c0fc5c94c6288e03a547eeb99e35887d4c983c47
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c483224278402f375ce48321a858b0baa88671dc

WR @ 479d43ab4f245c42b33e12f9b6f050045ec84ab3

https://treeherder.mozilla.org/#/jobs?repo=try&revision=01c795c153e134398974e1e3e673ffd400d66261
https://treeherder.mozilla.org/#/jobs?repo=try&revision=33ab3fd3ab621ad164645f9840c0cd01f6cd0416

Green

Not a whole lot has landed in WR since the last update, so maybe I'll wait until next week to do the next update.

Comment 6

[Markus Stange [:mstange]]

Attachment: Initialize the new field that was added in webrender commit 479d43ab4f245c42b33e12f9b6f050045ec84ab3.

Comment 7

[Markus Stange [:mstange]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #5)
> Not a whole lot has landed in WR since the last update, so maybe I'll wait
> until next week to do the next update.

Fixing bug 1406451 would be a big win for our Windows testers, at least.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

(In reply to Markus Stange [:mstange] from comment #6)
> Created attachment 8924823 [details] [diff] [review]
> Initialize the new field that was added in webrender commit
> 479d43ab4f245c42b33e12f9b6f050045ec84ab3.

Thanks!

(In reply to Markus Stange [:mstange] from comment #7)
> Fixing bug 1406451 would be a big win for our Windows testers, at least.

Ok, I can do the update today then.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

WR @ fae962bfd6e1997f4b921ee93c3c1cc5abca3256

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b656b3d3384d6a5481387c1f0f7a6718cb6bbf5
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5bb87ad2f274b55daa0fcc0101f14c3f87b7402d

Green

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1413178 - Update webrender to commit fae962bfd6e1997f4b921ee93c3c1cc5abca3256.

Review commit: https://reviewboard.mozilla.org/r/196266/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196266/

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1413178 - Initialize the new field that was added in webrender commit 479d43ab4f245c42b33e12f9b6f050045ec84ab3.

Review commit: https://reviewboard.mozilla.org/r/196268/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196268/

Comment 12

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1296d4d74f259dae97d5c7d902f336ca378ae2bd

Comment 13

[Markus Stange [:mstange]]

Comment on attachment 8925015 [details]
Bug 1413178 - Initialize the new field that was added in webrender commit 479d43ab4f245c42b33e12f9b6f050045ec84ab3.

https://reviewboard.mozilla.org/r/196268/#review201434

I missed this instance, which also needs to be initialized: http://searchfox.org/mozilla-central/rev/af86a58b157fbed26b0e86fcd81f1b421e80e60a/gfx/2d/ScaledFontDWrite.cpp#317

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8925015 [details]
Bug 1413178 - Initialize the new field that was added in webrender commit 479d43ab4f245c42b33e12f9b6f050045ec84ab3.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196268/diff/1-2/

Comment 15

[Kartikaya Gupta (email:[e-mail])]

^ updated. Also added the patch that regenerates the FFI header, which I somehow lost along the way. Try push to make sure it compiles everywhere: 

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e59bbfcbb02ebefb3f33c028d3a3201430406144

Also it's probably a good idea to have cbindgen generate constructors for the structs so we're required to initialize all the things at all the call sites. This is the second time in recent memory we've had this problem where a new field is added and the compiler doesn't tell us that it might be going uninitialized.

Comment 16

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1413178 - Re-generate FFI header.

Review commit: https://reviewboard.mozilla.org/r/196274/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196274/

Comment 17

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8925015 [details]
Bug 1413178 - Initialize the new field that was added in webrender commit 479d43ab4f245c42b33e12f9b6f050045ec84ab3.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196268/diff/2-3/

Comment 18

[Lee Salzman [:lsalzman]]

Comment on attachment 8925035 [details]
Bug 1413178 - Re-generate FFI header.

https://reviewboard.mozilla.org/r/196274/#review201500

Comment 19

[Lee Salzman [:lsalzman]]

Comment on attachment 8925015 [details]
Bug 1413178 - Initialize the new field that was added in webrender commit 479d43ab4f245c42b33e12f9b6f050045ec84ab3.

https://reviewboard.mozilla.org/r/196268/#review201502

Comment 20

[Lee Salzman [:lsalzman]]

Comment on attachment 8925014 [details]
Bug 1413178 - Update webrender to commit fae962bfd6e1997f4b921ee93c3c1cc5abca3256.

https://reviewboard.mozilla.org/r/196266/#review201504

Comment 21

[Lee Salzman [:lsalzman]]

Comment on attachment 8925035 [details]
Bug 1413178 - Re-generate FFI header.

https://reviewboard.mozilla.org/r/196274/#review201506

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/000dee2bb6ba
Update webrender to commit fae962bfd6e1997f4b921ee93c3c1cc5abca3256. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/033d34b29a64
Re-generate FFI header. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/e0f98b3490f6
Initialize the new field that was added in webrender commit 479d43ab4f245c42b33e12f9b6f050045ec84ab3. r=lsalzman

Comment 23

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/000dee2bb6ba
https://hg.mozilla.org/mozilla-central/rev/033d34b29a64
https://hg.mozilla.org/mozilla-central/rev/e0f98b3490f6