Closed Bug 1405793 Opened 4 years ago Closed 4 years ago

Port bug 1401946 to TB [Show profile path next to the open button]

Categories

(Thunderbird :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 58.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

Firefox shows now the path to the profile folder.
Attached patch aboutSupportPath.patch (obsolete) — Splinter Review
FX change: https://hg.mozilla.org/mozilla-central/rev/b5da04ce9e4372d20784eb49721210e268e91d42

We have already the show profile folder in about:support implemented with the ability to hide it and be a link. I added only the change for the xhtml file to be still in sync and changed slightly the js part to work with the added ID.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8915256 - Flags: review?(acelists)
Comment on attachment 8915256 [details] [diff] [review]
aboutSupportPath.patch

Review of attachment 8915256 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, seems to work.
But please update also the test (searching the tree for the id you are changing is useful):

diff --git a/mail/test/mozmill/content-tabs/test-about-support.js b/mail/test/mozmill/content-tabs/test-about-support.js
--- a/mail/test/mozmill/content-tabs/test-about-support.js
+++ b/mail/test/mozmill/content-tabs/test-about-support.js
@@ -202,17 +202,17 @@ function test_modified_pref_on_blacklist
  */
 function test_private_data() {
   let tab = open_about_support();
   let checkbox = content_tab_eid(tab, "check-show-private-data");
.
   // We use the profile path and some other element as an example
   // of a private-only element.
   let privateElem1 = find_private_element(tab);
-  let privateElem2 = content_tab_e(tab, "profile-dir-path");;
+  let privateElem2 = content_tab_e(tab, "profile-dir-box");
Attachment #8915256 - Flags: review?(acelists) → review+
Updated the test with the correct ID.
Attachment #8915256 - Attachment is obsolete: true
Attachment #8915471 - Flags: review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/38273b6b8bb0
Port bug 1401946 to TB [Show profile path next to the open button]. r=aceman
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 58.0
You need to log in before you can comment on or make changes to this bug.