1405875 - Remove "Regression-Test" code from the layout debugger

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Eric Rahm [:erahm]]

The RTest code in layout-debugger uses RDF [1] and we'd like to get rid of that. In order to do this we should just remove all "Regression-Test" related code from the layout debugger.

[1] http://searchfox.org/mozilla-central/rev/7ba03cebf1dcf3b4c40c85a4efad42a5022cf1ec/layout/tools/layout-debug/ui/content/layoutdebug.js#192-195

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7650a07019228d4f9b7c58c0902fcee2f9ca071

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

The tests that this operated on were removed in bug 652192.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c065724170b546112d9de95726a4e036cb08076

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: Remove old regression testing UI from layout debugger

The tests that were run using this UI were removed in bug 652192.  (They
did before-patch vs. after-patch comparisons of frame dumps, and didn't
actually have pass/fail state.)

MozReview-Commit-ID: 5qoeaFpEyQg

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: Remove regression testing backend from layout debugger

This removes the C++ and IDL for the UI removed in the previous patch.

MozReview-Commit-ID: bSkPnWopi9

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: Remove debug file mechanism from printing

This was used only by nsRegressionTester::DumpFrameModel, which was
removed in the previous patch.

MozReview-Commit-ID: I8fS7vzlFQw

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: Remove unused contentViewerFile property from browser and tabbrowser XBL bindings

This helps to make nsIContentViewerFile unused so that we can remove it
later in this patch series.

MozReview-Commit-ID: I0LvygpnCx8

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: Remove unneeded QueryInterface to nsIContentViewerFile

nsDocumentViewer is the only implementation of both nsIContentViewer and
of nsIContentViewerFile.

This helps to make nsIContentViewerFile unused so that we can remove it
later in this patch series.

MozReview-Commit-ID: EgsgrXfTmx1

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: Remove now-unused nsIContentViewerFile interface

This became unused as a result of the previous two patches, and the
earlier removal of nsRegressionTester::DumpFrameModel.

MozReview-Commit-ID: DoQ8C8XNCWW

Comment 10

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: Remove old dump/compare regression data methods on frames, and nsIFrameUtil interface and implementation

These became unused as a result of the removal of nsRegressionTester and
the removal of the printing debug file mechanism, earlier in this patch
sequence.

MozReview-Commit-ID: 9Tftf2AjpPb

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: diff -w of the entire patch stack, so you can look at the parts that require non-whitespace diff

Comment 12

[Mats Palmgren (inactive)]

Should layout/tools/tests/regression_tests.* be removed too?

Comment 13

[:Gijs (he/him)]

Comment on attachment 8915420 [details] [diff] [review]
Remove unused contentViewerFile property from browser and tabbrowser XBL bindings

Review of attachment 8915420 [details] [diff] [review]:
-----------------------------------------------------------------

TIL this existed - and now we're removing it! Oh well. :-)

Comment 14

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: Remove old regression test harness in layout/tools/tests/regression_tests.*

MozReview-Commit-ID: JWRxF8c09TP

Comment 15

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5d6b9275cb40349897b000e52f352087ab1273c
Bug 1405875 - Remove old regression testing UI from layout debugger.  r=mats

https://hg.mozilla.org/integration/mozilla-inbound/rev/92c0f810986fc9c6e3903a1246544a507452f2b4
Bug 1405875 - Remove regression testing backend from layout debugger.  r=mats

https://hg.mozilla.org/integration/mozilla-inbound/rev/3d7bbd9c6c096c50fb068a2f0ab68111d38da0f1
Bug 1405875 - Remove debug file mechanism from printing.  r=mats

https://hg.mozilla.org/integration/mozilla-inbound/rev/c5f636d9a86bb90d7fbf448a247256b6f26aaf30
Bug 1405875 - Remove unused contentViewerFile property from browser and tabbrowser XBL bindings.  r=Gijs

https://hg.mozilla.org/integration/mozilla-inbound/rev/46f3ad859456451e78990b6e8a62c5025ddb91de
Bug 1405875 - Remove unneeded QueryInterface to nsIContentViewerFile.  r=mats

https://hg.mozilla.org/integration/mozilla-inbound/rev/873f355209106292ed7fc47b09034396fa58f1b6
Bug 1405875 - Remove now-unused nsIContentViewerFile interface.  r=mats

https://hg.mozilla.org/integration/mozilla-inbound/rev/c559a947b2ad0739a3f0ca575f9add6f31bcc845
Bug 1405875 - Remove old dump/compare regression data methods on frames, and nsIFrameUtil interface and implementation.  r=mats

https://hg.mozilla.org/integration/mozilla-inbound/rev/694eb292fcf67b75fdeec89060665e601336c52f
Bug 1405875 - Remove old regression test harness in layout/tools/tests/regression_tests.*.  r=mats

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e5d6b9275cb4
https://hg.mozilla.org/mozilla-central/rev/92c0f810986f
https://hg.mozilla.org/mozilla-central/rev/3d7bbd9c6c09
https://hg.mozilla.org/mozilla-central/rev/c5f636d9a86b
https://hg.mozilla.org/mozilla-central/rev/46f3ad859456
https://hg.mozilla.org/mozilla-central/rev/873f35520910
https://hg.mozilla.org/mozilla-central/rev/c559a947b2ad
https://hg.mozilla.org/mozilla-central/rev/694eb292fcf6