1406353 - [macOS] [Photon] Regression: The Location Bar Drop Down Result List is 1px too high - followup

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Dale Harvey (:daleharvey)]

+++ This bug was initially created as a clone of Bug #1393406 +++

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3194.0 Safari/537.36

Steps to reproduce:

Latest Nightly from 23 Aug. 2017
macOS 10.12.6

1.) Type something into the Location Bar
2.) Take a look at the position of the Drop Down Result List


Actual results:

The Location Bar Drop Down Result List is 1px too high


Expected results:

The Location Bar Drop Down Result List must be 1px lower.

This is a regression after Bug 1391191 has been fixed now.

Comment 2

[Dale Harvey (:daleharvey)]

Opened a dupe for the follow up as mozreview said that was the correct way (kindoff annoying to have to file new bugs for follow up work on the same bug)

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: Bug 1406353 - Give autocomplete panel extra margin.

Review commit: https://reviewboard.mozilla.org/r/187222/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187222/

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8915947 [details]
Bug 1406353 - Give autocomplete panel extra margin.

https://reviewboard.mozilla.org/r/187222/#review192224

::: toolkit/themes/osx/global/autocomplete.css:49
(Diff revision 1)
>    background-color: -moz-Field;
>    font: icon;
>    -moz-appearance: none;
>  }
>  
> +/* OSX gives the awesomebar an extra 1px at the top - https://bugzilla.mozilla.org/show_bug.cgi?id=1393406 */

Can you refer more explicitly to aligning the popup with the nav bar border or something along these lines?

::: toolkit/themes/osx/global/autocomplete.css:52
(Diff revision 1)
>  }
>  
> +/* OSX gives the awesomebar an extra 1px at the top - https://bugzilla.mozilla.org/show_bug.cgi?id=1393406 */
> +#PopupAutoCompleteRichResult {
> +  margin-top: 1px;
> +}

This doesn't belong in this stylesheet. How about browser/themes/osx/browser.css?

Comment 5

[Dale Harvey (:daleharvey)]

Comment on attachment 8915947 [details]
Bug 1406353 - Give autocomplete panel extra margin.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/187222/diff/1-2/

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8915947 [details]
Bug 1406353 - Give autocomplete panel extra margin.

https://reviewboard.mozilla.org/r/187222/#review192236

::: toolkit/themes/osx/global/autocomplete.css:53
(Diff revision 2)
>  
> +/* OSX gives the awesomebar an extra 1px at the top - https://bugzilla.mozilla.org/show_bug.cgi?id=1393406 */
> +#PopupAutoCompleteRichResult {
> +  margin-top: 1px;
> +}
> +

Please drop the changes from this file

Comment 7

[Dale Harvey (:daleharvey)]

Comment on attachment 8915947 [details]
Bug 1406353 - Give autocomplete panel extra margin.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/187222/diff/2-3/

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 8915947 [details]
Bug 1406353 - Give autocomplete panel extra margin.

https://reviewboard.mozilla.org/r/187222/#review192300

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3e87f7a8f38
Give autocomplete panel extra margin. r=dao

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b3e87f7a8f38

Comment 11

[Mehmet]

Thank you very much. Looks good again in 58.0a1 (2017-10-09) (64-Bit).

Do you want to keep the fix in FF58 or want bring the two patches to FF57? Thanks.

Comment 12

[Dale Harvey (:daleharvey)]

Comment on attachment 8915947 [details]
Bug 1406353 - Give autocomplete panel extra margin.

Approval Request Comment
[Feature/Bug causing the regression]: Photon rework
[User impact if declined]: Misaligned awesomebar
[Is this code covered by automated tests?]: nope
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: Open awesomebar, see it is aligned with bottom of navigation bar
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: Nope
[Why is the change risky/not risky?]: Single line change of margin, can only really break positioning
[String changes made/needed]:

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8915947 [details]
Bug 1406353 - Give autocomplete panel extra margin.

Photon polish, beta57+

Comment 14

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8874107036534d1cf5e3a04b7eafd678dc610337

Comment 15

[roxleitan]

Verified fixed using the latest Nightly 58.0a1 (2017-10-19) on Mac OS X 10.12.

Comment 16

[Alexandru Simonca [:asimonca], Release Desktop QA]

Verified fixed using Beta 57.0b10 on Mac OS X 10.12.6.