[macOS] [Photon] Regression: The Location Bar Drop Down Result List is 1px too high - followup

VERIFIED FIXED in Firefox 57

Status

()

defect
P1
normal
VERIFIED FIXED
2 years ago
4 months ago

People

(Reporter: daleharvey, Assigned: daleharvey)

Tracking

({regression})

Trunk
Firefox 58
Unspecified
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox56 unaffected, firefox57 verified, firefox58 verified)

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #1393406 +++

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3194.0 Safari/537.36

Steps to reproduce:

Latest Nightly from 23 Aug. 2017
macOS 10.12.6

1.) Type something into the Location Bar
2.) Take a look at the position of the Drop Down Result List


Actual results:

The Location Bar Drop Down Result List is 1px too high


Expected results:

The Location Bar Drop Down Result List must be 1px lower.

This is a regression after Bug 1391191 has been fixed now.
Duplicate of this bug: 1393406
Opened a dupe for the follow up as mozreview said that was the correct way (kindoff annoying to have to file new bugs for follow up work on the same bug)
Assignee: nobody → dharvey
Comment on attachment 8915947 [details]
Bug 1406353 - Give autocomplete panel extra margin.

https://reviewboard.mozilla.org/r/187222/#review192224

::: toolkit/themes/osx/global/autocomplete.css:49
(Diff revision 1)
>    background-color: -moz-Field;
>    font: icon;
>    -moz-appearance: none;
>  }
>  
> +/* OSX gives the awesomebar an extra 1px at the top - https://bugzilla.mozilla.org/show_bug.cgi?id=1393406 */

Can you refer more explicitly to aligning the popup with the nav bar border or something along these lines?

::: toolkit/themes/osx/global/autocomplete.css:52
(Diff revision 1)
>  }
>  
> +/* OSX gives the awesomebar an extra 1px at the top - https://bugzilla.mozilla.org/show_bug.cgi?id=1393406 */
> +#PopupAutoCompleteRichResult {
> +  margin-top: 1px;
> +}

This doesn't belong in this stylesheet. How about browser/themes/osx/browser.css?
Attachment #8915947 - Flags: review?(dao+bmo) → review-
Comment on attachment 8915947 [details]
Bug 1406353 - Give autocomplete panel extra margin.

https://reviewboard.mozilla.org/r/187222/#review192236

::: toolkit/themes/osx/global/autocomplete.css:53
(Diff revision 2)
>  
> +/* OSX gives the awesomebar an extra 1px at the top - https://bugzilla.mozilla.org/show_bug.cgi?id=1393406 */
> +#PopupAutoCompleteRichResult {
> +  margin-top: 1px;
> +}
> +

Please drop the changes from this file
Attachment #8915947 - Flags: review?(dao+bmo) → review-
Status: NEW → ASSIGNED
Comment on attachment 8915947 [details]
Bug 1406353 - Give autocomplete panel extra margin.

https://reviewboard.mozilla.org/r/187222/#review192300
Attachment #8915947 - Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b3e87f7a8f38
Give autocomplete panel extra margin. r=dao
https://hg.mozilla.org/mozilla-central/rev/b3e87f7a8f38
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Thank you very much. Looks good again in 58.0a1 (2017-10-09) (64-Bit).

Do you want to keep the fix in FF58 or want bring the two patches to FF57? Thanks.
Comment on attachment 8915947 [details]
Bug 1406353 - Give autocomplete panel extra margin.

Approval Request Comment
[Feature/Bug causing the regression]: Photon rework
[User impact if declined]: Misaligned awesomebar
[Is this code covered by automated tests?]: nope
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: Open awesomebar, see it is aligned with bottom of navigation bar
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: Nope
[Why is the change risky/not risky?]: Single line change of margin, can only really break positioning
[String changes made/needed]:
Attachment #8915947 - Flags: approval-mozilla-beta?
Comment on attachment 8915947 [details]
Bug 1406353 - Give autocomplete panel extra margin.

Photon polish, beta57+
Attachment #8915947 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified fixed using the latest Nightly 58.0a1 (2017-10-19) on Mac OS X 10.12.
Verified fixed using Beta 57.0b10 on Mac OS X 10.12.6.
Status: RESOLVED → VERIFIED
See Also: → 1538367
You need to log in before you can comment on or make changes to this bug.