Closed
Bug 1391191
Opened 7 years ago
Closed 7 years ago
Consolidate navigator toolbox bottom border styling
Categories
(Firefox :: Theme, defect, P1)
Firefox
Theme
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Whiteboard: [reserve-photon-visual])
Attachments
(1 file)
- move to browser.inc.css - update color values on Mac on Windows - remove obsolete [customizing] adjustments on Windows 7 and 8
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 4•7 years ago
|
||
Note that the removal of the negative margin on Mac should make the nav-bar's vertical padding even, as it should be.
|
||
Updated•7 years ago
|
Iteration: --- → 57.2 - Aug 29
Flags: qe-verify?
|
|
Assignee | |
Updated•7 years ago
|
Flags: qe-verify? → qe-verify-
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8898200 [details] Bug 1391191 - Consolidate navigator toolbox bottom border styling. https://reviewboard.mozilla.org/r/169566/#review175262 Quite nice!
Attachment #8898200 -
Flags: review?(jhofmann) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2f78aad3c907 Consolidate navigator toolbox bottom border styling. r=johannh
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2f78aad3c907
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
|
||
Comment 8•7 years ago
|
||
Backed out in https://hg.mozilla.org/mozilla-central/rev/3dc98e773869 for Mac wpt permaorange like https://treeherder.mozilla.org/logviewer.html#?job_id=124264709&repo=mozilla-central, /scroll-anchoring/anchoring-with-bounds-clamping.html | Anchoring combined with scroll bounds clamping in the document. - assert_equals: expected 100 but got 101, the return of bug 1390246 and thus apparently of an extra pixel of Mac tabbar, after a few hours of that being fixed.
Status: RESOLVED → REOPENED
status-firefox57:
fixed → ---
Resolution: FIXED → ---
Target Milestone: Firefox 57 → ---
|
|
Assignee | |
Updated•7 years ago
|
| Comment hidden (mozreview-request) |
|
||
Comment 10•7 years ago
|
||
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5e8fc0f71bcf Consolidate navigator toolbox bottom border styling. r=johannh
|
|
||
Comment 11•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5e8fc0f71bcf
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
|
|
||
Comment 14•7 years ago
|
||
Screenshots: https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=a9d372645a32b8d23d44244f351639af9d73b96a&newProject=mozilla-central&newRev=c7570eb46382ee56d081e549b484341f400c864b Two things to note here: - The navbar height on OSX has increased by ~1px. (Might have caused bug 1393406) - The bottom border on Windows has become slightly lighter.
|
||
Comment 15•7 years ago
|
||
(In reply to Johann Hofmann [:johannh] from comment #14) > Screenshots: > > https://screenshots.mattn.ca/compare/?oldProject=mozilla- > central&oldRev=a9d372645a32b8d23d44244f351639af9d73b96a&newProject=mozilla- > central&newRev=c7570eb46382ee56d081e549b484341f400c864b > > Two things to note here: > > - The navbar height on OSX has increased by ~1px. (Might have caused bug > 1393406) This should be intended. --> See my comment in Bug 1393406. Thanks.
You need to log in
before you can comment on or make changes to this bug.
Description
•