1406841 - Migrate browser_webconsole_property_provider.js to the new frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1406841 - remove js property provider mochitests;

Review commit: https://reviewboard.mozilla.org/r/211496/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/211496/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8941230 [details]
Bug 1406841 - remove js property provider mochitests;

We could migrate the test to e10s (and remove the version in the old frontend, since it doesn't assert anything frontend-related). That's what I do in this patch

However I feel like the feature is already covered through:
- https://searchfox.org/mozilla-central/source/devtools/shared/webconsole/test/unit/test_js_property_provider.js
- https://searchfox.org/mozilla-central/source/devtools/shared/webconsole/test/test_jsterm_autocomplete.html

So maybe we should simply delete the browser mochitests here in favor of the xpcshell test + chrome mochitest?

Comment 3

[Brian Grinstead [:bgrins]]

(In reply to Julian Descottes [:jdescottes][:julian] from comment #2)
> We could migrate the test to e10s (and remove the version in the old
> frontend, since it doesn't assert anything frontend-related). That's what I
> do in this patch
> 
> However I feel like the feature is already covered through:
> -
> https://searchfox.org/mozilla-central/source/devtools/shared/webconsole/test/
> unit/test_js_property_provider.js
> -
> https://searchfox.org/mozilla-central/source/devtools/shared/webconsole/test/
> test_jsterm_autocomplete.html
> 
> So maybe we should simply delete the browser mochitests here in favor of the
> xpcshell test + chrome mochitest?

Yeah, we don't need this as a mochitest. Nothing relevant to the test requires the browser chrome. Good find - I'd go ahead and remove both versions.

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8941230 [details]
Bug 1406841 - remove js property provider mochitests;

https://reviewboard.mozilla.org/r/211496/#review217880

See comment 3

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8941230 [details]
Bug 1406841 - remove js property provider mochitests;

Thanks Brian! I'll send a new patch removing the existing tests.

Comment 6

[Julian Descottes [:jdescottes]]

Comment on attachment 8941230 [details]
Bug 1406841 - remove js property provider mochitests;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211496/diff/1-2/

Comment 7

[Brian Grinstead [:bgrins]]

Comment on attachment 8941230 [details]
Bug 1406841 - remove js property provider mochitests;

https://reviewboard.mozilla.org/r/211496/#review218324

Thanks!

Comment 8

[Julian Descottes [:jdescottes]]

Comment on attachment 8941230 [details]
Bug 1406841 - remove js property provider mochitests;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/211496/diff/2-3/

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: remove_unused_html_test_file.patch

Just noticed that this html file doesn't seem used anywhere in tests.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1404a7deedb57cc34c0932931abab0366b77f52c

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/715ae6e13c97
remove js property provider mochitests;r=bgrins

Comment 11

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/715ae6e13c97