1407840 - Update Debugger frontend (10/11/2017).

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Comment 1

[Jason Laster [:jlast]]

Attachment: patch-10-11-3.patch

This patch includes a fix for the browser content toolbox. It's also a larger patch because of the additional SVGs that are being included in theme/images.

Comment 2

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=20cf730ba94d0e977c716e2b698f574ec09e79b0

Comment 3

[Julian Descottes [:jdescottes]]

As I mentioned yesterday: you're hit with duplicates issue:

[task 2017-10-12T03:41:27.952Z] 03:41:27     INFO -  ERROR: The following duplicated files are not allowed:
[task 2017-10-12T03:41:27.952Z] 03:41:27     INFO -  browser/chrome/devtools/skin/images/debugger/refresh.svg
[task 2017-10-12T03:41:27.952Z] 03:41:27     INFO -  browser/chrome/devtools/skin/images/reload.svg
[task 2017-10-12T03:41:27.952Z] 03:41:27     INFO -  browser/chrome/devtools/skin/images/debugger/sad-face.svg
[task 2017-10-12T03:41:27.953Z] 03:41:27     INFO -  browser/chrome/devtools/skin/images/sad-face.svg

http://searchfox.org/mozilla-central/source/browser/installer/allowed-dupes.mn

(you can test locally by doing a ./mach package)

Comment 4

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=853f796ead1c064d8ca816e9299e72eb46d3807f

Comment 5

[Jason Laster [:jlast]]

Attachment: patch-10-11-4.patch

Comment 6

[Julian Descottes [:jdescottes]]

Comment on attachment 8917826 [details] [diff] [review]
patch-10-11-4.patch

LGTM, thanks! Browser Content Toolbox is fixed.

Small regression with setting breakpoints on lines that are right before disabled lines, but that's being tracked already.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d26fbc62c177
Update Debugger frontend (10-11). r=jdescottes

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing devtools' browser/base/content/test/static/browser_all_files_referenced.js:

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a84dcc0d240ef0537e6f0dcfd562fb49991c11d

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=d26fbc62c1777b0f754beb0bd1b599f35fe379de&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=136540105&repo=mozilla-inbound

TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 50, expected 0
TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://devtools/skin/images/debugger/angle-brackets.svg -

Comment 9

[Jason Laster [:jlast]]

Attachment: patch-10-12-4.patch

Comment 10

[Jason Laster [:jlast]]

Attachment: patch-10-12-4-2.patch

Comment 11

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=441d1d258237ce1ad04719aa61ed6e33bf8bb699

Comment 12

[Julian Descottes [:jdescottes]]

Comment on attachment 8917949 [details] [diff] [review]
patch-10-12-4-2.patch

Review of attachment 8917949 [details] [diff] [review]:
-----------------------------------------------------------------

Fixes the issue about unreferenced files.

As discussed, when bundle updates come with unusual changes we should have broader try runs, eg: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a46c1dc04bfa5fa920cb458aad5baaadf34309f

try: -b o -p linux64 -u mochitests -t none

Comment 13

[Julian Descottes [:jdescottes]]

(In reply to Julian Descottes [:jdescottes] from comment #12)
> Comment on attachment 8917949 [details] [diff] [review]
> patch-10-12-4-2.patch
> 
> Review of attachment 8917949 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Fixes the issue about unreferenced files.
> 
> As discussed, when bundle updates come with unusual changes we should have
> broader try runs, eg:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=6a46c1dc04bfa5fa920cb458aad5baaadf34309f
> 
> try: -b o -p linux64 -u mochitests -t none

Oh and even in the regular case we should use linux64 and not linux!

try: -b do -p linux64 -u mochitest-dt,mochitest-e10s-devtools-chrome,mochitest-o -t none --artifact

The test browser_all_files_referenced.js for instance only runs in linux64. I think several tests are linux64 only, because they can't fail on linux32 if they pass on linux64. So if we use linux64 we'll also get better try runs.

(and actually in this case, just devtools tests would have been enough)

Comment 14

[Julian Descottes [:jdescottes]]

Removing checkin needed. See test failure at https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a46c1dc04bfa5fa920cb458aad5baaadf34309f

Comment 15

[Jason Laster [:jlast]]

Try run
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a38ccb4166909a0f3e3cd859e32bd39e3082db66

Comment 16

[Jason Laster [:jlast]]

Attachment: patch-10-12-5.patch

Comment 17

[Jason Laster [:jlast]]

Attachment: patch-10-12-9.patch

Comment 18

[Jason Laster [:jlast]]

Attachment: patch-10-12-9.patch

Comment 19

[Jason Laster [:jlast]]

Attachment: patch-10-12-9.patch

Comment 20

[Jason Laster [:jlast]]

Attachment: patch-10-12-9.patch

Comment 21

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d85d21ef639ac2272d02933142e47c247545d54

Comment 22

[Jason Laster [:jlast]]

Attachment: patch-10-12-10.patch

Comment 23

[Julian Descottes [:jdescottes]]

Comment on attachment 8918140 [details] [diff] [review]
patch-10-12-10.patch

Review of attachment 8918140 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, try is green.

Will amend the commit message: should just be r=jdescottes

Comment 24

[Julian Descottes [:jdescottes]]

Attachment: patch-10-12-11.patch

fixed reviewer in commit message

Comment 25

[Julian Descottes [:jdescottes]]

(for the record the L10N job is busted on the try run but a quick look at the current state of this job on try makes me think this is a more global issue. Plus, it fails at repack on a browser/ image, can't see why our patch would have any impact there).

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e76eb11f034
Update Debugger frontend (10-12). r=jdescottes

Comment 27

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7e76eb11f034