1408573 - Crash in [@ OOM | large | mozalloc_abort | mozalloc_handle_oom | moz_xmalloc | mozilla::MakeUnique<T> | mozilla::layers::BufferRecycleBin::GetBuffer ]

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Darkspirit]

Nightly 58 x64 20171013100112 de_DE @ Windows 10 1703 (Radeon RX480).
fresh profile: webrender + webrendest + blob-images (&disabled pocket/GMP/EME)

I got this while watching my own mp4 video from bug 1408388 comment 2.
bp-13411fdb-aaeb-4eb0-be61-6f7b50171013 14.10.2017 00:17

Comment 1

[Darkspirit]

> (&disabled pocket/GMP/EME)
All bold prefs from "media.":
media.eme.enabled;false
media.eme.vp9-in-mp4.enabled;false
media.gmp-gmpopenh264.abi;x86_64-msvc-x64
media.gmp-gmpopenh264.lastUpdate;1507930882
media.gmp-gmpopenh264.version;1.6
media.gmp-manager.buildID;20171013100112
media.gmp-manager.lastCheck;1507930882
media.gmp-manager.url;
media.gmp-provider.enabled;false
media.gmp-widevinecdm.enabled;false
media.gmp-widevinecdm.visible;false
media.gmp.storage.version.observed;1
media.gmp.trial-create.enabled;false
media.hardware-video-decoding.failed;true

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

I'm assuming this is a webrender bug and therefore not a playback issue.

Comment 3

[Darkspirit]

(In reply to Anthony Jones (:kentuckyfriedtakahe, :k17e) from comment #2)
> I'm assuming this is a webrender bug and therefore not a playback issue.

btw, bug 1057757 has largely the same crash signature and ~30 crashs per day.

Comment 4

[Darkspirit]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #3)
> (In reply to Anthony Jones (:kentuckyfriedtakahe, :k17e) from comment #2)
> > I'm assuming this is a webrender bug and therefore not a playback issue.
> 
> btw, bug 1057757 has largely the same crash signature and ~30 crashs per day.

...but Firefox 48.0.2 at maximum. Sorry!

Comment 5

[Sotaro Ikeda [:sotaro]]

layers::BufferRecycleBin::GetBuffer() is not called in normal situation. If the function is called, the system might be already in low memory situation. OOM problem during video playback became better since Bug 1407069. Anyway, it seems better to change buffer allocation in BufferRecycleBin::GetBuffer() to fallible.

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Change buffer allocation to fallible

Comment 7

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1e7b5f1dc43be3e7a2a01bc708096e999aa560e

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6aeb83b22250
Change buffer allocation to fallible r=nical

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6aeb83b22250