1408741 - Menu label text shifts to the right-bottom when open the menu

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Alice0775 White]

Attachment: screenshot

[Tracking Requested - why for this release]:

Reproducible : always

Steps To Reproduce:
1. Enable Menu Bar
2. Open the menu item


Actual Results:
Menu label text shifts to the right-bottom 1px each.

Expected Results:
no shift


Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e121153e9597301293c90dd38600ec805e9ccc76&tochange=1c71b22afd8dbc35a9b4f2f1c73523a5d74a43d3

Regressed by:3ee3f976f092	Johann Hofmann — Bug 1368679 - Increase hover opacity of window control buttons, apply the hover effect on the menu bar. r=dao

:johannh
Your patch seems to cause the regression, Can you look this?

Comment 1

[Alice0775 White]

Attachment: screenshot

Comment 2

[Johann Hofmann [:johannh]]

Sure, thanks.

Comment 3

[Johann Hofmann [:johannh]]

Attachment: Bug 1408741 - Only give extra border on opened menubar menus in Windows classic.

This makes the menu slightly jump on opening in Windows 10 (and Windows 7 classic)
and has no visible effect whatsoever on Windows 7 Aero, so I'm cautiously removing it.

Review commit: https://reviewboard.mozilla.org/r/190172/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/190172/

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8919287 [details]
Bug 1408741 - Only give extra border on opened menubar menus in Windows classic.

https://reviewboard.mozilla.org/r/190172/#review195848

::: toolkit/themes/windows/global/menu.css
(Diff revision 1)
>    color: -moz-menubarhovertext;
>  }
>  
> -menubar > menu[_moz-menuactive="true"][open="true"] {
> -  border-width: 3px 1px 1px 3px;
> -}

The whole point of this rule is to shift the active menu; the border is transparent and treated like padding. But perhaps this is supposed to target classic themes only?

Comment 5

[Johann Hofmann [:johannh]]

(In reply to Dão Gottwald [::dao] from comment #4)
> Comment on attachment 8919287 [details]
> Bug 1408741 - Remove extra border on opened menubar menus.
> 
> https://reviewboard.mozilla.org/r/190172/#review195848
> 
> ::: toolkit/themes/windows/global/menu.css
> (Diff revision 1)
> >    color: -moz-menubarhovertext;
> >  }
> >  
> > -menubar > menu[_moz-menuactive="true"][open="true"] {
> > -  border-width: 3px 1px 1px 3px;
> > -}
> 
> The whole point of this rule is to shift the active menu; the border is
> transparent and treated like padding. But perhaps this is supposed to target
> classic themes only?

This causes shifting in Win 7 classic theme as well. Do you mean the shift on open is a feature?

Comment 6

[Dão Gottwald [:dao]]

(In reply to Johann Hofmann [:johannh] from comment #5)
> (In reply to Dão Gottwald [::dao] from comment #4)
> > Comment on attachment 8919287 [details]
> > Bug 1408741 - Remove extra border on opened menubar menus.
> > 
> > https://reviewboard.mozilla.org/r/190172/#review195848
> > 
> > ::: toolkit/themes/windows/global/menu.css
> > (Diff revision 1)
> > >    color: -moz-menubarhovertext;
> > >  }
> > >  
> > > -menubar > menu[_moz-menuactive="true"][open="true"] {
> > > -  border-width: 3px 1px 1px 3px;
> > > -}
> > 
> > The whole point of this rule is to shift the active menu; the border is
> > transparent and treated like padding. But perhaps this is supposed to target
> > classic themes only?
> 
> This causes shifting in Win 7 classic theme as well. Do you mean the shift
> on open is a feature?

Yep.

Comment 7

[Johann Hofmann [:johannh]]

Comment on attachment 8919287 [details]
Bug 1408741 - Only give extra border on opened menubar menus in Windows classic.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/190172/diff/1-2/

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 8919287 [details]
Bug 1408741 - Only give extra border on opened menubar menus in Windows classic.

https://reviewboard.mozilla.org/r/190172/#review196366

::: toolkit/themes/windows/global/menu.css:119
(Diff revision 2)
>  }
>  
>  /* ::::: menu/menuitems in menubar ::::: */
>  
>  menubar > menu {
>    border: 2px solid transparent;

Should this rule move as well?

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 8919287 [details]
Bug 1408741 - Only give extra border on opened menubar menus in Windows classic.

https://reviewboard.mozilla.org/r/190172/#review196412

Comment 10

[Johann Hofmann [:johannh]]

(In reply to Dão Gottwald [::dao] from comment #8)
> Comment on attachment 8919287 [details]
> Bug 1408741 - Only give extra border on opened menubar menus in Windows
> classic.
> 
> https://reviewboard.mozilla.org/r/190172/#review196366
> 
> ::: toolkit/themes/windows/global/menu.css:119
> (Diff revision 2)
> >  }
> >  
> >  /* ::::: menu/menuitems in menubar ::::: */
> >  
> >  menubar > menu {
> >    border: 2px solid transparent;
> 
> Should this rule move as well?

That makes the menu smaller on Windows 10, but I guess that's a feature since it's quite large. I'll update the patch.

Comment 11

[Johann Hofmann [:johannh]]

Comment on attachment 8919287 [details]
Bug 1408741 - Only give extra border on opened menubar menus in Windows classic.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/190172/diff/2-3/

Comment 12

[Dão Gottwald [:dao]]

Comment on attachment 8919287 [details]
Bug 1408741 - Only give extra border on opened menubar menus in Windows classic.

https://reviewboard.mozilla.org/r/190172/#review196726

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a02e5bd8e9b
Only give extra border on opened menubar menus in Windows classic. r=dao

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1a02e5bd8e9b

Comment 15

[Valentina Claudia Ona]

I verified this issue using latest Nightly 58.0a1 with Build ID 20171023220222 on Windows 10 x64.
I will mark this as verified fixed.