1368679 - Menu bar and window control button hover feedback lacks contrast on dark titlebar

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Alice0775 White]

Attachment: bug.png

Almost I can not recognize the hover effect.

Steps To Reproduce:
1. Enable Menubar
2. Mouse hover over menu or keypress alt key

Actual Results:
Almost I can not recognize active menu.

Expected Results:
More lighter background color.


PS. I think hover active color of caption buttons are also less contrast

Comment 1

[Jim Jeffery not reading bug-mail 1/2/11]

Tabs in background are too dark to see sites that just happen have a dark FavIcon, Impossible to see so selecting tab is slower since you can't pick out tab by FavIcon. 

I would also point out that NOTHING in Win10 has a 'dark' toolbar, they are all very light is not White.  So this theme is a poor attempt to blend with Win10.

Comment 2

[Chris Peterson [:cpeterson]]

(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #1)
> Tabs in background are too dark to see sites that just happen have a dark
> FavIcon, Impossible to see so selecting tab is slower since you can't pick
> out tab by FavIcon. 

https://github.com/ is a good example of bad favicon contrast. Maybe the background color behind favicons on dark background tabs can be brighter so favicons' transparent pixels have more contrast while leaving the rest of the tab dark?

Comment 3

[Alex Thayer [:alexical] (she/her)]

(In reply to Chris Peterson [:cpeterson] from comment #2)
> (In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #1)
> > Tabs in background are too dark to see sites that just happen have a dark
> > FavIcon, Impossible to see so selecting tab is slower since you can't pick
> > out tab by FavIcon. 
> 
> https://github.com/ is a good example of bad favicon contrast. Maybe the
> background color behind favicons on dark background tabs can be brighter so
> favicons' transparent pixels have more contrast while leaving the rest of
> the tab dark?

Another example that makes this pretty conspicuous is the new tab favicon if you have the activity stream add-on set up.

All of the offenders I've seen tend to be grayscale favicons, usually with only one shade of gray (not accounting for anti-aliasing pixels). They're almost always visually pleasing if you invert them, but it seems a bit hairy to try to do that automatically.

Comment 4

[Julien Cristau [:jcristau]]

If I'm not mistaken this is behind the MOZ_PHOTON_THEME ifdef which isn't riding to beta55, so updating flags.

Comment 5

[Justin Dolske [:Dolske]]

I've seen a few people point to this bug as the one for "dark favicons hard to see with the new dark Photon titlebar". But... that's not actually what this bug was filed about.

It's actually not Photon-specific; the same issue exists with the Compact Dark theme, which has shipped with DevEdition for quite some time. So bug 1094357 would be more relevant for the favicon issue. (I'm a bit surprised it has so little activity, given that Github is the canonical example of a problematic icon, and that's a common site for developers to use.)

Comment 6

[Johann Hofmann [:johannh]]

Attachment: Bug 1368679 - Increase hover opacity of window control buttons, apply the hover effect on the menu bar.

Review commit: https://reviewboard.mozilla.org/r/160968/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/160968/

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8889912 [details]
Bug 1368679 - Increase hover opacity of window control buttons, apply the hover effect on the menu bar.

https://reviewboard.mozilla.org/r/160968/#review168294

::: browser/themes/windows/browser-aero.css:306
(Diff revision 1)
>    @media (-moz-windows-default-theme) {
> +%ifdef MOZ_PHOTON_THEME
> +    #main-menubar > menu {
> +      -moz-appearance: none;
> +    }
> +%endif

Why is this not in the same block as the other rules that you modified? Is this really meant to take effect under other circumstances?

Comment 8

[Johann Hofmann [:johannh]]

Comment on attachment 8889912 [details]
Bug 1368679 - Increase hover opacity of window control buttons, apply the hover effect on the menu bar.

https://reviewboard.mozilla.org/r/160968/#review168296

::: browser/themes/windows/browser-aero.css:306
(Diff revision 1)
>    @media (-moz-windows-default-theme) {
> +%ifdef MOZ_PHOTON_THEME
> +    #main-menubar > menu {
> +      -moz-appearance: none;
> +    }
> +%endif

Indeed, that wouldn't be helpful. I'll change it.

Comment 9

[Johann Hofmann [:johannh]]

Comment on attachment 8889912 [details]
Bug 1368679 - Increase hover opacity of window control buttons, apply the hover effect on the menu bar.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/160968/diff/1-2/

Comment 10

[Dão Gottwald [:dao]]

Comment on attachment 8889912 [details]
Bug 1368679 - Increase hover opacity of window control buttons, apply the hover effect on the menu bar.

https://reviewboard.mozilla.org/r/160968/#review169152

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ee3f976f092
Increase hover opacity of window control buttons, apply the hover effect on the menu bar. r=dao

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3ee3f976f092

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 14

[Johann Hofmann [:johannh]]

We don't have the dark Photon color in 56, so this shouldn't be an issue.

Comment 15

[Md. Rahimul Islam]

I have successfully reproduced this bug with Nightly 55.0a1 (2017-05-30) on windows 10(32bit)

this bug is verified fix with  latest nightly 57.0a1 (2017-08-15) (32-bit)

Build ID: 20170815100349
Mozilla/5.0 (Windows NT 10.0; rv:57.0) Gecko/20100101 Firefox/57.0

Comment 16

[ovidiu boca[:Ovidiu]]

I verified this on Windows 10 x64 with Nightly 57.0a1(20178-08-15) and I can't reproduce this anymore. I will this as verified fixed.

Comment 17

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello all, 

I managed to reproduce this issue again with the latest 65.0b5(20181217180946) build.

I pulled the following regression : https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d8e07613f15e55f43d654af8708ffa0cba1710d1&tochange=d341e1dcdfeff2ba187ada77af2e77f4b430604d 

It seems that the issue which causes this may be Bug 1511905 - Fix window controls' hover and active colors in light titlebars on Windows 10.

Johann, how would you like us to proceed with this issue?

Comment 18

[Liz Henry (:lizzard) (relman/hg->git project)]

Since this was closed a year ago, I'm opening a new bug for the new issue.