1409278 - stylo: Obsolete StyleAnimationValue

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Boris Chiou [:boris]]

This is the final step (M6) of stylo-animation [1].

Now we don't store StyleAnimationValue on the main thread (bug 1338087), and bug 1340005 makes the compositor always use ServoAnimationValue. Therefore, we can obsolete/drop StyleAnimationValue and make our animation code simpler.

[1] https://public.etherpad-mozilla.org/p/stylo-animation

Comment 1

[Jonathan Watt [:jwatt]]

No outstanding blockers, but the etherpad still shows the following as outstanding:

Use Servo's interpolation on the compositor [ boris ]
  * we re-use nsCSSValueSharedList, we can convert transform
    directly into TransformFunction list and vise versa

Comment 2

[Hiroyuki Ikezoe (:hiro)]

(In reply to Jonathan Watt [:jwatt] (needinfo? me) from comment #1)
> No outstanding blockers, but the etherpad still shows the following as
> outstanding:
> 
> Use Servo's interpolation on the compositor [ boris ]
>   * we re-use nsCSSValueSharedList, we can convert transform
>     directly into TransformFunction list and vise versa

This has been actually done in bug 1340005.

Comment 3

[Jonathan Watt [:jwatt]]

What steps do we still need to take to close this bug?

Comment 4

[Hiroyuki Ikezoe (:hiro)]

StyleAnimationValue struct itself has been already #ifdef outed in bug 1430014.  Once we drop MOZ_OLD_STYLE in bug 1395112, the rest of work is to clean it up (rename file or some such).

Comment 5

[Jonathan Watt [:jwatt]]

Right, but the removal will happen in bug 1395112, no? So this bug seems done. Can we close it?

Comment 6

[Hiroyuki Ikezoe (:hiro)]

I am not sure what bug 1395112 will be done exactly.  If the bug doesn't clean up AnimationValue (which is now inside StyleAnimationValue.h) and relevant stuff, I am concerned that we will forget about it.  Anyway I am fine with either way (clean it up in that bug or in this bug).

Comment 7

[Jonathan Watt [:jwatt]]

That makes sense. And in fact while StyleAnimationValue has been removed, AnimationValue has not. Morphing this bug to now cover that post-StyleAnimationValue cleanup is confusing though, not least because it leaves the blocking/depends-on relationship the wrong way around. Rather than doing that let's close this bug and work on the cleanup in a folllow-up -- I've filed bug 1447627.