Closed Bug 1421509 Opened 7 years ago Closed 6 years ago

Drop duplicated code from nsStyleTransformMatrix

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1551991

People

(Reporter: boris, Assigned: boris)

References

Details

After enabling Stylo, we implemented the following features on Servo: 1. Decompose 2d/3d transform [1] 2. Convert a transform list into a gfx matrix [2] We have some duplicated implementation on Gecko for the above functions in nsStyleTransformMatrix (e.g. ReadTransform). We are still using them, but they could be replaced with our Servo implementation to reduce the code size. Maybe we could do this after obsoleting StyleAnimationValue (Bug 1409278), I think. [1] https://searchfox.org/mozilla-central/rev/9f3bd430c2b132c86c46126a0548661de876799a/servo/components/style/properties/helpers/animated_properties.mako.rs#1717-1912 [2] https://searchfox.org/mozilla-central/rev/9f3bd430c2b132c86c46126a0548661de876799a/servo/components/style/values/generics/transform.rs#686

I almost forgot this bug XD. At least we should drop the "Decompose 2d/3d transform".

Assignee: nobody → boris.chiou

This was fixed by https://phabricator.services.mozilla.com/D31314.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.