1410352 - Optimize Overflow menu for touch

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Johann Hofmann [:johannh]]

+++ This bug was initially created as a clone of Bug #1409698 +++

The overflow menu doesn't currently get resized when accessed through touch gestures. I didn't do this in bug 1364896 because the overflow menu wasn't updated to Photon style back then.

The fact that it doesn't adjust automatically already tells me there might be some digging in XUL code necessary to find out which touch events aren't propagated correctly here.

Comment 1

[Johann Hofmann [:johannh]]

> The fact that it doesn't adjust automatically already tells me there might be some digging in XUL code necessary to find out which touch events aren't propagated correctly here.

Hm, I'm not sure why, but upon further digging the event seems to get properly propagated now. I'm a bit confused, but everything seems good now. I'll get a patch ready.

Comment 2

[Johann Hofmann [:johannh]]

Attachment: Bug 1410352 - Make the overflow menu adhere to touchmode sizing.

Review commit: https://reviewboard.mozilla.org/r/192870/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/192870/

Comment 3

[Nihanth Subramanya [:nhnt11]]

Comment on attachment 8921837 [details]
Bug 1410352 - Make the overflow menu adhere to touchmode sizing.

https://reviewboard.mozilla.org/r/192870/#review198088

I did a quick smoke test. Everything LGTM.

Comment 4

[Johann Hofmann [:johannh]]

Comment on attachment 8921837 [details]
Bug 1410352 - Make the overflow menu adhere to touchmode sizing.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/192870/diff/1-2/

Comment 5

[Johann Hofmann [:johannh]]

Comment on attachment 8921837 [details]
Bug 1410352 - Make the overflow menu adhere to touchmode sizing.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/192870/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc55d4e3d13d
Make the overflow menu adhere to touchmode sizing. r=nhnt11

Comment 7

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

Backed out for eslint failure at browser/components/customizableui/CustomizableUI.jsm:4339: 'aEvent' is already declared in the upper scope:

https://hg.mozilla.org/integration/autoland/rev/7f889616f052ea124d2c76f0c0dc4f71fec32a83

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=139496938&repo=autoland

Comment 8

[Johann Hofmann [:johannh]]

Comment on attachment 8921837 [details]
Bug 1410352 - Make the overflow menu adhere to touchmode sizing.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/192870/diff/3-4/

Comment 9

[Johann Hofmann [:johannh]]

Thanks!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d620c9c79de
Make the overflow menu adhere to touchmode sizing. r=nhnt11

Comment 11

[Attila Craciun [:arny]]

https://hg.mozilla.org/mozilla-central/rev/1d620c9c79de

Comment 12

[ovidiu boca[:Ovidiu]]

Attachment: touch.png

I tested this issue on Surface Pro 4 Windows 10 x64 with FF Nightly 58.0a1(2017-11-06), I opened many tabs until the tab bar was overflowed and I touch the down arrow, please see the attached file with the actual result, I don't think that the overflow menu is optimized.

Comment 13

[Johann Hofmann [:johannh]]

(In reply to ovidiu boca[:Ovidiu] from comment #12)
> Created attachment 8925517 [details]
> touch.png
> 
> I tested this issue on Surface Pro 4 Windows 10 x64 with FF Nightly
> 58.0a1(2017-11-06), I opened many tabs until the tab bar was overflowed and
> I touch the down arrow, please see the attached file with the actual result,
> I don't think that the overflow menu is optimized.

Ah, you're talking about a different overflow menu. What you're referring to is also called "tab list menu" (covered in bug 1397755). What we optimized in this bug is the overflow menu in the navigation toolbar (right click e.g. on the library button and select "Pin to Overflow Menu").

Comment 14

[ovidiu boca[:Ovidiu]]

Thanks Johann, I manage to verify this issue on Surface Pro 4 with Windows 10 with FF Nightly 58.0a1(2017-11-06), I followed the instruction from comment 13 "right click e.g. on the library button and select "Pin to Overflow Menu"" and I can pin the Library on the Overflow menu. I will mark this as verified fixed.