Optimize Overflow menu for touch

VERIFIED FIXED in Firefox 58

Status

()

defect
P1
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: johannh, Assigned: johannh)

Tracking

58 Branch
Firefox 58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 wontfix, firefox58 verified)

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(2 attachments)

Assignee

Description

2 years ago
+++ This bug was initially created as a clone of Bug #1409698 +++

The overflow menu doesn't currently get resized when accessed through touch gestures. I didn't do this in bug 1364896 because the overflow menu wasn't updated to Photon style back then.

The fact that it doesn't adjust automatically already tells me there might be some digging in XUL code necessary to find out which touch events aren't propagated correctly here.
Flags: qe-verify+
Assignee

Updated

2 years ago
Component: Toolbars and Customization → Theme
Assignee

Updated

2 years ago
No longer depends on: 1409698
Assignee

Updated

2 years ago
Blocks: photon-touch
Assignee

Comment 1

2 years ago
> The fact that it doesn't adjust automatically already tells me there might be some digging in XUL code necessary to find out which touch events aren't propagated correctly here.

Hm, I'm not sure why, but upon further digging the event seems to get properly propagated now. I'm a bit confused, but everything seems good now. I'll get a patch ready.
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Priority: P4 → P1
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8921837 [details]
Bug 1410352 - Make the overflow menu adhere to touchmode sizing.

https://reviewboard.mozilla.org/r/192870/#review198088

I did a quick smoke test. Everything LGTM.
Attachment #8921837 - Flags: review?(nhnt11) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 6

2 years ago
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cc55d4e3d13d
Make the overflow menu adhere to touchmode sizing. r=nhnt11
Backed out for eslint failure at browser/components/customizableui/CustomizableUI.jsm:4339: 'aEvent' is already declared in the upper scope:

https://hg.mozilla.org/integration/autoland/rev/7f889616f052ea124d2c76f0c0dc4f71fec32a83

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=139496938&repo=autoland
Flags: needinfo?(jhofmann)
Comment hidden (mozreview-request)
Assignee

Comment 9

2 years ago
Thanks!
Flags: needinfo?(jhofmann)

Comment 10

2 years ago
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1d620c9c79de
Make the overflow menu adhere to touchmode sizing. r=nhnt11

Comment 11

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1d620c9c79de
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Posted image touch.png
I tested this issue on Surface Pro 4 Windows 10 x64 with FF Nightly 58.0a1(2017-11-06), I opened many tabs until the tab bar was overflowed and I touch the down arrow, please see the attached file with the actual result, I don't think that the overflow menu is optimized.
Flags: needinfo?(jhofmann)
Assignee

Comment 13

2 years ago
(In reply to ovidiu boca[:Ovidiu] from comment #12)
> Created attachment 8925517 [details]
> touch.png
> 
> I tested this issue on Surface Pro 4 Windows 10 x64 with FF Nightly
> 58.0a1(2017-11-06), I opened many tabs until the tab bar was overflowed and
> I touch the down arrow, please see the attached file with the actual result,
> I don't think that the overflow menu is optimized.

Ah, you're talking about a different overflow menu. What you're referring to is also called "tab list menu" (covered in bug 1397755). What we optimized in this bug is the overflow menu in the navigation toolbar (right click e.g. on the library button and select "Pin to Overflow Menu").
Flags: needinfo?(jhofmann)
Thanks Johann, I manage to verify this issue on Surface Pro 4 with Windows 10 with FF Nightly 58.0a1(2017-11-06), I followed the instruction from comment 13 "right click e.g. on the library button and select "Pin to Overflow Menu"" and I can pin the Library on the Overflow menu. I will mark this as verified fixed.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.