1410617 - Deadcode in nsStreamLoader::OnStartRequest on logical comparison

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Just like in bug 1410379, we have the same issue in nsStreamLoader.cpp

In file included from /data/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/netwerk/base/Unified_cpp_netwerk_base4.cpp:11:
/data/jenkins/workspace/firefox-clang-last/netwerk/base/nsStreamLoader.cpp:76:35: error: comparison 'uint64_t' (aka 'unsigned long') > 18446744073709551615 is always false [-Werror,-Wtautological-constant-compare]
      if (uint64_t(contentLength) > std::numeric_limits<size_t>::max()) {
          ~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1410617 - compare uint64_t with size_t only on 32bit platforms.

Review commit: https://reviewboard.mozilla.org/r/191766/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191766/

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1410617 - Fix a tiny typo

Review commit: https://reviewboard.mozilla.org/r/191768/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191768/

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8920778 [details]
Bug 1410617 - compare uint64_t with size_t only on 32bit platforms.

https://reviewboard.mozilla.org/r/191766/#review196988

Comment 4

[Andi [:andi]]

Comment on attachment 8920779 [details]
Bug 1410617 - Fix a tiny typo

https://reviewboard.mozilla.org/r/191768/#review196990

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54de317b854a
compare uint64_t with size_t only on 32bit platforms. r=valentin
https://hg.mozilla.org/integration/autoland/rev/ea486c5d3380
Fix a tiny typo r=andi

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/54de317b854a
https://hg.mozilla.org/mozilla-central/rev/ea486c5d3380