1411131 - Giant box-shadows cause things to flicker and makes them ugly

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Darkspirit]

Attachment: 2017-10-24_04-55-07.mp4

Nightly 58 x64 20171023220222 de_DE @ Debian Testing (KDE, Radeon RX480)
main profile: gpu process + layers force accel + webrender + webrendest + blob-image + omtp

"box-sizing: border-box" lets flicker things and make them very ugly.
See attached video.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

I don't see this on OS X; I tried with and without blob-image. Can you still repro if OMTP is off?

Comment 2

[Darkspirit]

Nightlx 58 x64 20171023220222 de_DE @ Debian Testing (KDE, Radeon RX480)
FRESH PROFILE: layers force accel + webrender

Broken and fixed on the same way.

Comment 3

[Darkspirit]

Btw this bug does not occur when I zoom out to 90%.

Comment 4

[Markus Stange [:mstange]]

I can see glitches in the chrome just by scrolling over that web page. I'll try to create a reduced testcase.

Comment 5

[Markus Stange [:mstange]]

Attachment: testcase

This testcase causes strange shadow parts to show up on my toolbars, and it makes the back button's icon invisible.

Comment 6

[Markus Stange [:mstange]]

I filed https://github.com/servo/webrender/issues/1922 upstream.

Comment 7

[Darkspirit]

Nightly 58 x64 20171024100135 de_DE @ Windows 10 1703 (Radeon RX480)
fresh profile: gfx.webrender.enabled
1) https://schlafguru.com/2017/10/13/test/#comments looks broken like on Debian (attachment 8921306 [details]), but only at >= 110% zoom.
2) attachment 8921557 [details] looks broken at >= 120% zoom after pressing Pos1 and End multiple times.

Comment 8

[Darkspirit]

Possibly the same problem: https://cloud.google.com/skus/?currency=USD

Comment 9

[Darkspirit]

Nightly 58 x64 20171101104430 de_DE @ Debian Testing (KDE, Radeon RX480)

layers.acceleration.force-enabled, gfx.webrender.enabled, gfx.webrender.blob-images

mozregression --good 2017-11-01 --bad 20171031220132 --profile-persistence clone-first --find-fix
>  5:01.71 INFO: First good revision: 431ffc8fe9eee53d743b2b088dd70f5bcceb7172
>  5:01.71 INFO: Last bad revision: adf78145b388b8611ff4ce4741522b454a418e35
>  5:01.71 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=adf78145b388b8611ff4ce4741522b454a418e35&tochange=431ffc8fe9eee53d743b2b088dd70f5bcceb7172

This got fixed by the latest webrender update.

Comment 11

[Darkspirit]

(Jan Andre Ikenmeyer [:darkspirit] from comment #9)
> This got fixed by the latest webrender update.

:mstange, can you confirm this?
Who (has to become Assignee) & what fixed it? Thank you.

Your GitHub issue: https://github.com/servo/webrender/issues/1922

Commits between the previous and the fixing webrender update: https://github.com/servo/webrender/compare/4b8493d6bdc64d2d83202ac15b06b0d4b14c6e76...c0194de78ce26106a8497484dc8d159069e3a482

Comment 12

[Markus Stange [:mstange]]

I can confirm this. It was fixed by https://github.com/servo/webrender/pull/1954 .

Comment 13

[Darkspirit]

Verified in comment 9 and comment 12.