1411230 - Synced tabs search box icon should move to the left

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Valentina Claudia Ona]

Attachment: sidebar.png

Mozilla/5.0 (Windows NT 6.1; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID 20171023220222

Affected version: Firefox Beta 57.0b10 and Nightly 58.0a1

Affected platforms: Windows 7 x32, Windows 10 x64, Ubuntu 16.04

[Steps to reproduce]: 
1. Launch Nightly 58.0a1
2. Enable the sidebar

[Expected result]: The search icon, text from the search field and search box match with the spec.

[Actual result]:  -The search icon is on the right side(on Ubuntu and Windows)
-The text from the search field is "Search synced tabs" (on Ubuntu and Windows)
-The search box has square corners(on Windows)

[Note:] Please see the attachment!! 

This is a follow up of 1355330

Comment 1

[Dão Gottwald [:dao]]

(In reply to Valentina Claudia Ona from comment #0)
> [Actual result]:  -The search icon is on the right side(on Ubuntu and
> Windows)

Yeah, that's buggy because the synced tabs sidebar is implemented in HTML and a big mess. :(

> -The text from the search field is "Search synced tabs" (on Ubuntu and
> Windows)

Not sure if this was actually supposed to change or just an arbitrary difference in the mockup.

> -The search box has square corners(on Windows)

As far as I remember, Stephen said the native textbox styling is fine here.

Reducing the scope of this bug to the first issue so that it's actionable.

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 1411230 - Move synctab sidebar search icon to left.

Review commit: https://reviewboard.mozilla.org/r/199412/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199412/

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8928187 [details]
Bug 1411230 - Move synctab sidebar search icon to left.

https://reviewboard.mozilla.org/r/199412/#review204536

::: browser/themes/linux/syncedtabs/sidebar.css:42
(Diff revision 1)
> -  width: 16px;
> -  height: 16px;
>    background-image: url(chrome://global/skin/icons/search-textbox.svg);
>    background-repeat: no-repeat;
> -  background-position: center;
> -  display: inline-block;
> +  background-size: 12px 12px;
> +  background-position: left center;

Looks like this doesn't take RTL into account. You can check by setting intl.uidirection to 1 in about:config.

Comment 4

[Dale Harvey (:daleharvey)]

Comment on attachment 8928187 [details]
Bug 1411230 - Move synctab sidebar search icon to left.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199412/diff/1-2/

Comment 5

[Dale Harvey (:daleharvey)]

Filed a new bug for not seeing RTL @ https://bugzilla.mozilla.org/show_bug.cgi?id=1417577

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8928187 [details]
Bug 1411230 - Move synctab sidebar search icon to left.

https://reviewboard.mozilla.org/r/199412/#review205002

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ce9c18806c4
Move synctab sidebar search icon to left. r=dao

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/9ce9c18806c4

Comment 9

[Mohammad Maruf Rahman]

I can reproduce this issue with Nightly 59.0a1 (2017-11-016) on Windows 10 pro, 64 Bit!

This bug's fix is verified with latest Nightly!

Build ID 	20171122220056
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0

Comment 10

[Valentina Claudia Ona]

I verified this issue using Latest Nightly 59.0a1 with Build ID 20171116220410 on Ubuntu 16.04, Windows 7 x64 and Windows 10 x64. I will mark this as verified fixed.