Restyle synced tabs sidebar to match Photon spec

VERIFIED FIXED in Firefox 57

Status

()

Firefox
General
P1
normal
VERIFIED FIXED
a year ago
8 months ago

People

(Reporter: adw, Assigned: nhnt11)

Tracking

(Depends on: 1 bug, Blocks: 2 bugs)

unspecified
Firefox 57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 verified, firefox58 verified)

Details

(Whiteboard: [reserve-photon-visual][p3], URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

a year ago
Restyle the synced tabs sidebar to match Photon spec as needed.
Flags: qe-verify+
Priority: -- → P2
QA Contact: gwimberly
Whiteboard: [photon] → [photon-structure]
Just making sure this is the bug is going to fix the sidebar search issue for Synced Tabs: dark outline, and no magnifying glass icon like the other ones.
Moving teams.
Whiteboard: [photon-structure] → [photon-visual]
QA Contact: gwimberly → brindusa.tot
Blocks: 1325171
Priority: P2 → P3
Whiteboard: [photon-visual] → [reserve-photon-visual][p3]
Whiteboard: [reserve-photon-visual][p3] → [photon-visual][p3]
Priority: P3 → P2

Updated

11 months ago
Priority: P2 → P3
Whiteboard: [photon-visual][p3] → [reserve-photon-visual][p3]

Updated

11 months ago
Priority: P3 → P4

Updated

11 months ago
Depends on: 1390586
Comment hidden (mozreview-request)
(Assignee)

Comment 4

11 months ago
Patch is WIP, it doesn't touch Windows yet.
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED

Updated

11 months ago
Duplicate of this bug: 1390590
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 8

11 months ago
mozreview-review
Comment on attachment 8899430 [details]
Bug 1355330 - Update synced tabs sidebar styling.

https://reviewboard.mozilla.org/r/170710/#review179662

::: browser/themes/windows/syncedtabs/sidebar.css:95
(Diff revision 3)
>    background-repeat: no-repeat;
>    background-position: center;
> -  padding-top: 5px;
>    min-width: 9px; /* The image's width is 9 pixels */
>    height: 9px;
> +  margin: auto;

This accurately centers the arrow.
(Assignee)

Updated

11 months ago
Attachment #8899430 - Flags: review?(dao+bmo)

Updated

11 months ago
Iteration: --- → 57.3 - Sep 19
Priority: P4 → P1
QA Contact: brindusa.tot → ovidiu.boca

Comment 9

11 months ago
mozreview-review
Comment on attachment 8899430 [details]
Bug 1355330 - Update synced tabs sidebar styling.

https://reviewboard.mozilla.org/r/170710/#review181690
Attachment #8899430 - Flags: review?(dao+bmo) → review+

Comment 10

11 months ago
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5413ff07da1d
Update synced tabs sidebar styling. r=dao

Updated

11 months ago
Duplicate of this bug: 1396532

Comment 12

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5413ff07da1d
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57

Comment 13

10 months ago
Created attachment 8910724 [details]
Sync tab.png

I verified this issue but on Windows x10 and Ubuntu 16.04 I have 2 different sidebar search.
I attached some screenshots and I want to know which of this are correct?

Differences are:

-The search icon is in the right side(Ubuntu and Windows 10)
-The text from the search field is "Search synced tabs" (Ubuntu and Windows 10)
-The search box has square corners(Windows 10)
Flags: needinfo?(nhnt11)
(Assignee)

Comment 14

9 months ago
(In reply to Valentina Claudia Ona from comment #13)
> Created attachment 8910724 [details]
> Sync tab.png
> 
> I verified this issue but on Windows x10 and Ubuntu 16.04 I have 2 different
> sidebar search.
> I attached some screenshots and I want to know which of this are correct?
> 
> Differences are:
> 
> -The search icon is in the right side(Ubuntu and Windows 10)
> -The text from the search field is "Search synced tabs" (Ubuntu and Windows
> 10)
> -The search box has square corners(Windows 10)

Yup, these are known issues and I believe they are not a priority to address for now.
Flags: needinfo?(nhnt11)
Thanks for looking into this. 
From your point of view, I should mark this as verified based on the fact that the mentioned issues are known? Or should I log them and then mark this as verified? 
Thanks
Flags: needinfo?(nhnt11)
(Assignee)

Comment 16

9 months ago
I think it would be nice to log the issues, yeah. Could you file bugs and then mark this as verified as you suggested? Thanks!
Flags: needinfo?(nhnt11)
I verified this issue using latest Nightly on Mac OS X 10.12, Ubuntu 16.04, Windows 7 x32 and Windows 10 x64. I will mark this as verified fixed and I filled a new bug 1411230  for Windows and Ubuntu issues.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
status-firefox58: --- → verified
Flags: qe-verify+

Updated

9 months ago
Blocks: 1411230

Updated

8 months ago
Depends on: 1418259

Updated

8 months ago
Depends on: 1421419
You need to log in before you can comment on or make changes to this bug.