1523595 - The height of columns in a column container split by a column-span are too large

Status: RESOLVED FIXED

(Core :: Layout: Columns, defect, P3)

Description

[Mats Palmgren (inactive)]

Attachment: Testcase

STR

1. set "layout.css.column-span.enabled" to true in about:config
2. load the attached testcase

ACTUAL RESULTS
The height of the columns below the column-span is too large.
The specified height (2em) has already been consumed by
the columns at the top and the column-span block.
The height of the columns above the column-span is also
too large.

EXPECTED RESULTS
The fragments of the blue block should have 1px height
(and there should be a lot of overflow columns created).
The top columns should be auto-sized to one line-height.
The bottom part of the lime border should be roughly
centered under the column-span grey box.
(See Chrome for correct results.)

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

We currently have height:100% on ::-moz-column-set and ::-moz-column-content.

https://searchfox.org/mozilla-central/rev/c07aaf12f13037c1f5a343d31f8291549e57373f/layout/style/res/ua.css#257-259

Comment 3

[Sean Voisen (:svoisen)]

Bulk moving bugs that have been triaged P4 to P3 (P4 is reserved for WPT bugs).

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1523595 Part 1 - Remove margin-bottom from column-balancing-nested-000.html and its reference. r=dbaron

This patch does the same thing as bug 1548118 Part 3, but for
column-balancing-nested-000.html.

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1523595 Part 2 - Add missing NS_FRAME_HAS_MULTI_COLUMN_ANCESTOR for nested ColumnSetWrapper. r=dbaron

Bug 1507244 changes how NS_FRAME_HAS_MULTI_COLUMN_ANCESTOR is propagated
to the child, but I forget to add the bit for nested ColumnSetWrapper.

Currently, no other code depends on this bit being set on nested
ColumnSetWrapper, but Part 3 will. Without this patch,
testing/web-platform/tests/css/css-multicol/multicol-nested-margin-002.xht
will fail with Part 3.

Depends on D31674

Comment 6

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1523595 Part 3 - Apply ColumnSetWrapper's block size constraint to the available size when creating BlockReflowInput for ColumnSet. r=dbaron

We used to apply the column container's block size constraint on top of
the available block size in nsColumnSetFrame::ChooseColumnStrategy().
After column-span is enabled, ColumnSet is no longer the outermost
column frame, we need to apply the block size constraint of
ColumnSetWrapper to the available size when creating the ReflowInput for
ColumnSet so that ColumnSet can use it to compute the max column block
size in ChooseColumnStrategy().

multicol-breaking-004.html is copied and modified from
multicol-breaking-002.html with border-bottom added to test
"box-decoration-break: clone".

Depends on D31675

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1523595 Part 4 - Enable column-span for multicol-fill-auto-block-children-{001,002}.xht, and fix a reference file. r=dbaron

The default margin-top of h1 is 0.67em in Firefox (specified in
layout/style/res/html.css) as well as in Google Chrome.

The test reference tries to override it to avoid margin-collapse, but
using 0.66em can cause rounding issue on MacOS that make the test
failed.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eca304c5282a
Part 1 - Remove margin-bottom from column-balancing-nested-000.html and its reference. r=dbaron
https://hg.mozilla.org/integration/autoland/rev/4ce4fef39673
Part 2 - Add missing NS_FRAME_HAS_MULTI_COLUMN_ANCESTOR for nested ColumnSetWrapper. r=dbaron
https://hg.mozilla.org/integration/autoland/rev/9cd5c207529c
Part 3 - Apply ColumnSetWrapper's block size constraint to the available size when creating BlockReflowInput for ColumnSet. r=dbaron
https://hg.mozilla.org/integration/autoland/rev/f8f4f9da5fc8
Part 4 - Enable column-span for multicol-fill-auto-block-children-{001,002}.xht, and fix a reference file. r=dbaron

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/eca304c5282a
https://hg.mozilla.org/mozilla-central/rev/4ce4fef39673
https://hg.mozilla.org/mozilla-central/rev/9cd5c207529c
https://hg.mozilla.org/mozilla-central/rev/f8f4f9da5fc8

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17467 for changes under testing/web-platform/tests

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged