Show that an Extension is controlling the default notifications permission

VERIFIED FIXED in Firefox 64

Status

P5
enhancement
VERIFIED FIXED
a year ago
5 months ago

People

(Reporter: bsilverberg, Assigned: prathiksha, Mentored)

Tracking

(Blocks: 1 bug)

58 Branch
mozilla64
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox64 verified)

Details

Attachments

(4 attachments)

(Reporter)

Description

a year ago
This is another "Project Jazz" bug that has to do with the fact that a new browserSettings API is going to land, called webNotificationsDisabled. If this is set to `true` by an extension then the default permissions for that profile will be to deny permission to issue web notifications.

I'm not sure exactly how this should be shown in the UI, but it's something that should be covered by Jazz. See [1] for a bit of discussion about this.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1364942#c19

Updated

a year ago
status-firefox57: --- → wontfix
This should be displayed next to the checkbox that bug 1368744 is adding. See mockups in that bug. :)
Depends on: 1368744

Updated

a year ago
Severity: normal → enhancement
Priority: -- → P5
(Assignee)

Updated

a year ago
Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
(Reporter)

Updated

a year ago
Mentor: bob.silverberg
Mentor: bob.silverberg → mstriemer

Updated

9 months ago
Product: Toolkit → WebExtensions
(Assignee)

Comment 2

7 months ago
Show that an Extension is controlling the default notifications permission
status-firefox57: wontfix → ---
status-firefox58: affected → ---
(Assignee)

Comment 3

7 months ago
Posted file manifest.json
(Assignee)

Comment 4

7 months ago
Posted file test.js
Background script for the test extension.

Comment 5

5 months ago
Pushed by prathikshaprasadsuman@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/225546ee5bd2
Show that an Extension is controlling the default notifications permission. r=flod,johannh

Comment 6

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/225546ee5bd2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64

Comment 7

5 months ago
Will this bug require manual testing? if so please specify some steps to validate or set the 'qe-verify-' flag, thank you
Flags: needinfo?(bob.silverberg)

Comment 8

5 months ago
Moving the needinfo to Mark (because he has been the mentor on this bug).
Flags: needinfo?(bob.silverberg) → needinfo?(mstriemer)
(Reporter)

Comment 9

5 months ago
Thanks Luca! I was just about to do that myself. :-)
(Assignee)

Comment 10

5 months ago
To test -

1. Install an extension that globally overrides the desktop-notification permission or load one manually(the manifest.json and test.js files are attached above) in about:debugging.

2. If you're using the attached test extension, click on the extension's browser action icon in the toolbar to set the override setting to true.

3. Open Preferences > Privacy and Security > Permissions > Settings button(Notifications Permission).

4. You should be able to see a section at the bottom of the settings dialog indicating that an extension is controlling the notifications permission setting.

5. Should be able to disable the extension by clicking the "Disable Extension" button and instructions to re-enable the extension should appear in the same section.
(Assignee)

Comment 11

5 months ago
See Comment 10 for steps to validate this change. Thanks!
Flags: needinfo?(mstriemer) → qe-verify+

Comment 12

5 months ago
Thank you for the testing steps. I've successfully validated that the Settings is showing the notification using Nightly  	65.0a1 and 64.0b3. Both running on windows 10 x64.
Status: RESOLVED → VERIFIED
status-firefox64: fixed → verified

Comment 13

5 months ago
You need to log in before you can comment on or make changes to this bug.